Skip to content

chore: remove stackTrace => path dependency - #34763

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged

chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:stack_trace_path_2

Conversation

@pavelfeldman

@pavelfeldmanPavel Feldman (pavelfeldman) commented Feb 13, 2025

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38543 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

yury-s
Yury Semikhatsky (yury-s) approved these changes Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
return fileUrl;

let path = decodeURIComponent(fileUrl.slice(7));
if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))

@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))

@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!

Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

import * as url from 'url';

@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit e697b1a into microsoft:mainFeb 13, 2025
This was referenced Feb 13, 2025
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
chore: remove stackTrace => path dependency by pavelfeldman · Pull Request #34763 · microsoft/playwright · GitHub
Skip to content
chore: remove stackTrace => path dependency - #34763
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Feb 13, 2025
Merged
chore: remove stackTrace => path dependency#34763
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
pavelfeldman:stack_trace_path_2
Conversation
@pavelfeldman
@pavelfeldmanPavel Feldman (pavelfeldman)
commented
Feb 13, 2025

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Feb 13, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
11 flaky⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:398:5 › launchServer › should terminate network waiters @chromium-ubuntu-22.04-node20 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:578:5 › selector generator › should generate multiple: noId @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
38543 passed, 793 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
approved these changes
Feb 13, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 return fileUrl;

 let path = decodeURIComponent(fileUrl.slice(7));
 if (path.startsWith('/') && /^[a-zA-Z]:/.test(path.slice(1)))
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(path.startsWith('/')&&/^[a-zA-Z]:/.test(path.slice(1)))
if(/^\/[a-zA-Z]:/.test(path))
@pavelfeldmanPavel Feldman (pavelfeldman)Feb 13, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up!
Comment threadpackages/playwright-core/src/utils/isomorphic/stackUtils.ts
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

import * as url from 'url';
@yury-sYury Semikhatsky (yury-s)Feb 13, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it platform-specific?
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit e697b1a
into
microsoft:mainFeb 13, 2025

This was referenced Feb 13, 2025

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@yury-s