Uh oh!
There was an error while loading. Please reload this page.
chrome: remove state from isomorphic utils - #34795
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoFeb 14, 2025
Merged
Conversation
Pavel Feldman (pavelfeldman)force-pushed
the
DEPS_client
branch
2 times, most recently
from
February 14, 2025 03:30
61b0bc1 to
f2e34a8Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"1 failed 12 flaky38541 passed, 793 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)force-pushed
the
DEPS_client
branch
from
February 14, 2025 21:49
f2e34a8 to
ae6449cCompareYury Semikhatsky (yury-s)
approved these changes
Feb 14, 2025
| export function createConnectionFactory(platform: Platform): () => Connection { | ||
| setPlatformForSelectors(platform); | ||
| setPlatformForEventEmitter(platform); |
There was a problem hiding this comment.
EventEmitter could accept platform in its constructor.
| } | ||
| } | ||
| function formatCallLog(platform: Platform, log: string[] | undefined): string { |
There was a problem hiding this comment.
This could be formatted on server instead.
| export const DEFAULT_TIMEOUT = 30000; | ||
| export const DEFAULT_LAUNCH_TIMEOUT = 3 * 60 * 1000; // 3 minutes | ||
| export class TimeoutSettings { |
There was a problem hiding this comment.
Consider putting it into common?
| */ | ||
| import { isUnderTest } from '../utils/isomorphic/debug'; | ||
| let isUnderTest = () => false; |
There was a problem hiding this comment.
can probably be refactored to accept it in the constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.