Uh oh!
There was an error while loading. Please reload this page.
chore: change generated filename for toMatchAriaSnapshot from .yml to .snapshot.yml - #34931
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Simon Knott <info@simonknott.de>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
| _resolveSnapshotPath(template: string | undefined, defaultTemplate: string, pathSegments: string[]) { | ||
| const subPath = path.join(...pathSegments); | ||
| const parsedSubPath = path.parse(subPath); | ||
| const parsedSubPath = parsePathMultiExt(subPath); |
There was a problem hiding this comment.
Why do we need these changes? Could you please provide an example of what goes wrong without the change in this line?
There was a problem hiding this comment.
as discussed offline, this is needed because path.parse turns foo.snapshot.yml into { name: 'foo.snapshot', ext: 'yml' }, while our usecase needs { name: 'foo', ext: 'snapshot.yml' }. This is a subtle breaking change though, because it'll also impact extensions like .foo.txt. So we decided to make it a special case for .snapshot.yml instead.
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Simon Knott <info@simonknott.de>
| export function sanitizeFilePathBeforeExtension(filePath: string): string { | ||
| const ext = path.extname(filePath); | ||
| export function sanitizeFilePathBeforeExtension(filePath: string, ext = path.extname(filePath)): string { |
There was a problem hiding this comment.
For some reason, I feel uncomfortable with non-constant default values. I'd rather see any code evaluated during the function call inside the function body.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 flaky38058 passed, 650 skipped Merge workflow run. |
No description provided.