fix: do not allow to override cookie header - #35168

Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:test-cookie-redirect
Mar 20, 2025
Merged

fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:test-cookie-redirect

Conversation

@yury-s

@yury-sYury Semikhatsky (yury-s) commented Mar 12, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Behavior before this PR regarding 'Cookie' header already varied between browsers:

  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.

To override cookies addCookies should be used instead.

See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.

Reference #35154

@zuzusik

Viktor Zozuliak (zuzusik) commented Mar 12, 2025

Copy link
Copy Markdown

I can't agree this closes #35154

This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154

@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s) changed the title test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman) requested changes Mar 13, 2025
View reviewed changes

@pavelfeldmanPavel Feldman (pavelfeldman) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.

Comment threaddocs/src/api/class-route.md Outdated
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1

3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38811 passed, 811 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests others"

3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest

21770 passed, 512 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

10 failed
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest
❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge

115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

228661 passed, 9112 skipped
✔️✔️✔️

Merge workflow run.

@yury-s
Yury Semikhatsky (yury-s) merged commit b83e0af into microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s) deleted the test-cookie-redirect branch March 20, 2025 23:35
This was referenced Mar 20, 2025
Closed
Closed
Closed
@yury-sYury Semikhatsky (yury-s) mentioned this pull request Apr 24, 2025
Merged
This was referenced Aug 1, 2025
Merged
Open
cloudjiang pushed a commit to cloudjiang/playwright that referenced this pull request Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: do not allow to override cookie header - #35168
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Mar 20, 2025
Merged
fix: do not allow to override cookie header#35168
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:test-cookie-redirect
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Mar 12, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Behavior before this PR regarding 'Cookie' header already varied between browsers:
  • Chromium would not respect the 'Cookie' header if there was one with the same name in its cookie jar. If there was no corresponding cooke in the cookie jar, Chromium would apply one from the overrides.
  • WebKit would always take one from the cookie jar.
To override cookies addCookies should be used instead.
See https://docs.google.com/document/d/1LXMSP4GVxFLYJxA6z4upKqwkgD-TnVCGeX-daS4VQjk/edit?usp=sharing for mode details.
Reference #35154
@zuzusik
Viktor Zozuliak (zuzusik)
commented
Mar 12, 2025

Copy link


Copy Markdown

I can't agree this closes #35154
This adds tests to existing functionality, but I believe it has a bug, which is clearly reproduced in the repo linked to #35154
@github-actions

This comment has been minimized.

Sign in to view
@yury-sYury Semikhatsky (yury-s)
changed the title
test: overridden cookie header on redirectfix: do not allow to override cookie headerMar 13, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
requested changes
Mar 13, 2025
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we can break people for now good reason. They already have very poor understanding of the interception and now their scenarios will stop working.
Comment threaddocs/src/api/class-route.md
Outdated

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [playwright-test] › tests/playwright.spec.ts:877:5 › page.pause() should disable test timeout @ubuntu-latest-node20-1
3 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
38811 passed, 811 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
3 flaky⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
21770 passed, 512 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Mar 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
10 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @tracing-webkit

❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
115 flaky⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-ubuntu-24.04 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-macos-14-large 
⚠️ [chromium-library] › tests/library/global-fetch-cookie.spec.ts:190:1 › should remove cookie with expires far in the past @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @chromium-tip-of-tree-ubuntu-22.04--headed 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [chromium-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @chromium-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts💯3 › should scroll into view element in iframe @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:652:3 › browser › should pass with matching certificates and trailing slash @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:54:5 › download event › should report download when navigation turns into download Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/download.spec.ts:244:5 › download event › should error when saving after deletion @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:398:3 › should click in iframe with padding @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:398:7 › cli codegen › should generate frame locators with id attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/popup.spec.ts:20:3 › should inherit user agent from browser context Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › launchServer › disconnected event should be emitted when browser is closed or server is closed @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:678:1 › should restore control values @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/beforeunload.spec.ts:79:3 › should access page after beforeunload @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:364:7 › cli codegen › should fill [contentEditable] @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/capabilities.spec.ts:217:3 › make sure that XMLHttpRequest upload events are emitted correctly @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-15-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
228661 passed, 9112 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit b83e0af
into
microsoft:mainMar 20, 2025
@yury-s
Yury Semikhatsky (yury-s)
deleted the

test-cookie-redirect

branch
March 20, 2025 23:35

This was referenced Mar 20, 2025

Closed


Closed


Closed

@yury-sYury Semikhatsky (yury-s)
mentioned this pull request
Apr 24, 2025
 Merged


This was referenced Aug 1, 2025
 Merged


Open

cloudjiang pushed a commit
to cloudjiang/playwright
that referenced
this pull request
Aug 15, 2026
@yury-s
fix: do not allow to override cookie header (microsoft#35168)
e8f6adb
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@yury-s@zuzusik@pavelfeldman