fix(IndexedDB): don't crash on empty IDB by Skn0tt · Pull Request #35779 · microsoft/playwright

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

Simon Knott (Skn0tt) · 2025-04-28T12:54:59Z

Resolves#35760

Copilot

Pull Request Overview

This PR addresses an issue where an empty IndexedDB could cause a crash by adding a dedicated test and introducing early returns in the storage state retrieval logic.

Adds a new test to ensure proper handling of an empty IndexedDB.
Implements early return checks in the storage script to prevent crashes when no object stores are present.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/library/browsercontext-storage-state.spec.ts	Introduces a test to verify safe handling of empty IndexedDB databases.
packages/playwright-core/src/server/storageScript.ts	Adds early return checks to avoid processing empty IndexedDB instances.

Copilot · 2025-04-28T12:55:26Z

 const db = await this._idbRequestToPromise(openRequest);
+
+ if (db.objectStoreNames.length === 0)
+ return;


The early return here returns undefined, which is inconsistent with the branch at line 88 that returns an object with empty stores. To avoid potential type inconsistencies for callers, consider unifying the behavior so that both cases return a consistent storage state representation.
Suggested change
return;
return{restored: false};

c'mon copilot! restore doesn't have a return value anyways, it's OK that it returns undefined

github-actions · 2025-04-28T13:45:16Z

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39092 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

fix(IndexedDB): don't crash on empty IDB
3eea75c

Simon Knott (Skn0tt) requested review from Copilot and Dmitry Gozman (dgozman)April 28, 2025 12:54

Simon Knott (Skn0tt) self-assigned this Apr 28, 2025

CopilotAI reviewed Apr 28, 2025
View reviewed changes

Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes

Simon Knott (Skn0tt) merged commit ed23a93 into microsoft:mainApr 28, 2025

coderabbitaiBot mentioned this pull request May 14, 2026
chore: adopt Playwright CLI skill over Playwright MCP michellepace/devflow#55
Merged
5 tasks

Uh oh!

Conversation

Simon Knott (Skn0tt) commented Apr 28, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIApr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Simon Knott (Skn0tt)Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 28, 2025

Test results for "tests 1"

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Simon Knott (Skn0tt) commented Apr 28, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIApr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Simon Knott (Skn0tt)Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 28, 2025

Test results for "tests 1"

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Simon Knott (Skn0tt) commented Apr 28, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIApr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Simon Knott (Skn0tt)Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 28, 2025

Test results for "tests 1"

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation