chore: inject builtins through esbuild - #35800

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-inject-builtins
Apr 29, 2025
Merged

chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-inject-builtins

Conversation

@dgozman

@dgozmanDmitry Gozman (dgozman) commented Apr 29, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

There are multiple changes:

  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.

References #35683.

@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests others"

1 fatal errors, not part of any test

3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest

19924 passed, 457 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)

6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39106 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
20 failed
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04
❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge

166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge

234422 passed, 9209 skipped
✔️✔️✔️

Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) merged commit 3b01354 into microsoft:mainApr 29, 2025
This was referenced Apr 29, 2025
Closed
Closed
Closed
Nanne (whazor) pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: inject builtins through esbuild - #35800
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Apr 29, 2025
Merged
chore: inject builtins through esbuild#35800
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-inject-builtins
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
Apr 29, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
There are multiple changes:
  • builtins are now injected through esbuild instead of being imported explicitly;
  • UtilityScript is now always evaluated through an init script;
  • pageBinding.ts is merged into the utility script;
  • builtins are now stored on the utility script instance;
  • all generated scripts are preprocessed before evaluation to include runtimeGuid.
References #35683.
@dgozman
chore: inject builtins through esbuild
6c914d1
There are multiple changes:
- builtins are now injected through esbuild instead of being imported explicitly;
- `UtilityScript` is now always evaluated through an init script;
- `pageBinding.ts` is merged into the utility script;
- builtins are now stored on the utility script instance;
- all generated scripts are preprocessed before evaluation to include `runtimeGuid`.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
3 flaky⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest 
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest 
19924 passed, 457 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [default] › run-tests.spec.ts:1153:5 › should produce output twice vscode-extension (@vscode-extension)
6 flaky⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39106 passed, 803 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Apr 29, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
1 fatal errors, not part of any test
20 failed

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @channel-chromium-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-macos-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @chrome-windows-latest

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest

❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest

❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04

❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04

❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
166 flaky⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/page-clock.spec.ts:327:3 › popup › should run time before popup @channel-chromium-ubuntu-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:85:3 › should have pages in persistent context @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-macos-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @chrome-ubuntu-22.04 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:146:5 › should upload large file @chrome-windows-latest 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @chrome-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-macos-14-xlarge 
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:184:7 › cli codegen › should generate frame locators (3) @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-macos-14-large 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1202:1 › should open trace-1.31 @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chromium-tip-of-tree-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/global-fetch-cookie.spec.ts:130:1 › should send secure cookie over http for localhost @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:430:7 › cli codegen › should generate frame locators with testId @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/pause.spec.ts:217:5 › pause › should skip input when resuming @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/slowmo.spec.ts:55:5 › slowMo › Page SlowMo check @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:333:5 › launchServer › should throw when used after isConnected returns false @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1016:1 › should include metainfo @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-macos-latest 
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @msedge-macos-latest 
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest 
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-ubuntu-22.04 
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:468:7 › page screenshot › mask option › should work with elementhandle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:556:7 › page screenshot › mask option › should work when mask color is not pink #F0F @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-ubuntu-24.04 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:477:7 › page screenshot › mask option › should mask multiple elements @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @webkit-headed-windows-latest 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:285:5 › post data › should amend binary post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-macos-15-xlarge 
234422 passed, 9209 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 3b01354
into
microsoft:mainApr 29, 2025

This was referenced Apr 29, 2025

Closed


Closed


Closed

Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
@dgozman
chore: inject builtins through esbuild (microsoft#35800)
aaf1b0b
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@pavelfeldman