chore: move timeout handling to the client - #35988

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-timeout-on-client
May 20, 2025
Merged

chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-timeout-on-client

Conversation

@dgozman

@dgozmanDmitry Gozman (dgozman) commented May 18, 2025

Copy link
Copy Markdown
Collaborator

References #35987.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented May 18, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

12 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest
❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest
❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest
❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest
❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge

145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest

239469 passed, 9341 skipped
✔️✔️✔️

Merge workflow run.

yury-s
Yury Semikhatsky (yury-s) reviewed May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
title: Go back
parameters:
timeout: number?
timeout: number

@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?

@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.

Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 failed
❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39229 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) merged commit 6532d7c into microsoft:mainMay 20, 2025
This was referenced May 20, 2025
Closed
Closed
Closed
@dgozmanDmitry Gozman (dgozman) mentioned this pull request Jun 2, 2025
Merged
@YusukeIwakiYusuke Iwaki (YusukeIwaki) mentioned this pull request Jun 15, 2025
Closed
@agg23Adam Gastineau (agg23) mentioned this pull request Jun 17, 2025
Merged
@Skn0ttSimon Knott (Skn0tt) mentioned this pull request Jun 30, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: move timeout handling to the client - #35988
Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
May 20, 2025
Merged
chore: move timeout handling to the client#35988
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom 
dgozman:chore-timeout-on-client
Conversation
@dgozman
@dgozmanDmitry Gozman (dgozman)
commented
May 18, 2025

Copy link


Copy Markdown

Collaborator
References #35987.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 18, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
12 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @channel-chromium-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:910:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest

❌ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-beta-macos-latest

❌ [chromium-library] › library/browsertype-connect.spec.ts:400:5 › run-server › should terminate network waiters @chrome-macos-latest

❌ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest

❌ [webkit-library] › library/popup.spec.ts💯3 › should inherit touch support from browser context @tracing-webkit

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
145 flaky⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:487:5 › selector generator › should prefer role other input[type] @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:738:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:925:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @chrome-macos-latest 
⚠️ [chromium-library] › library/selector-generator.spec.ts:163:5 › selector generator › should handle first non-unique data-testid @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-page] › page/expect-matcher-result.spec.ts:164:5 › toBeChecked({ checked }) should have expected @chromium-headed-macos-14-xlarge 
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers Radoslav Kirilov (@smoke) @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13 
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1309:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13--headed 
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-tip-of-tree-windows-latest--headed 
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:977:1 › should show action source @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:361:3 › should disambiguate by header @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:173:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/hit-target.spec.ts:366:3 › should detect overlaid element in a transformed iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:334:7 › cli codegen › should generate frame locators with title attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:366:7 › cli codegen › should generate frame locators with name attribute @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:840:1 › should register custom elements @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large 
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large 
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:107:11 › should proxy local network requests › with other bypasses › localhost @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-beta-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-cookies-third-party.spec.ts:137:5 › should(not) block third party cookies - persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:291:1 › should work with routeWebSocket @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:227:7 › should work with --save-har and --save-har-glob in nunit @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:580:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest 
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1347:1 › should highlight locator in iframe while typing @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › library/inspector/pause.spec.ts:97:5 › pause › should pause after a navigation @msedge-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit 
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @tracing-webkit 
⚠️ [webkit-library] › library/popup.spec.ts:129:3 › should use viewport size from window features @tracing-webkit 
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:169:5 › page screenshot › should clip elements to the viewport @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221:5 › post data › should amend post data @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:726:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:248:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:830:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened Radoslav Kirilov (@smoke) @webkit-macos-14-large 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:216:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:246:5 › post data › should amend method and post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:104:3 › should fail with WebSocket if not ignored @webkit-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-windows-latest 
239469 passed, 9341 skipped

✔️✔️✔️
Merge workflow run.
yury-s
Yury Semikhatsky (yury-s)
reviewed
May 19, 2025
View reviewed changes
Comment threadpackages/protocol/src/protocol.yml
 title: Go back
 parameters:
 timeout: number?
 timeout: number
@yury-sYury Semikhatsky (yury-s)May 19, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
@dgozmanDmitry Gozman (dgozman)May 19, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to roll into languages and see how it goes.
Comment threadpackages/playwright-core/src/client/browserContext.ts
Comment threadpackages/playwright-core/src/server/android/android.ts
Comment threadpackages/playwright-core/src/server/dispatchers/elementHandlerDispatcher.ts
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
May 20, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
3 failed

❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)

❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot vscode-extension (@vscode-extension)
7 flaky⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-ubuntu-22.04-node18 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18 
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18 
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18 
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1 
39229 passed, 804 skipped

✔️✔️✔️
Merge workflow run.
@dgozman
Dmitry Gozman (dgozman)
merged commit 6532d7c
into
microsoft:mainMay 20, 2025

This was referenced May 20, 2025

Closed


Closed


Closed

@dgozmanDmitry Gozman (dgozman)
mentioned this pull request
Jun 2, 2025
 Merged

@YusukeIwakiYusuke Iwaki (YusukeIwaki)
mentioned this pull request
Jun 15, 2025

Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jun 17, 2025
 Merged

@Skn0ttSimon Knott (Skn0tt)
mentioned this pull request
Jun 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman@pavelfeldman@yury-s