Uh oh!
There was an error while loading. Please reload this page.
chore: two-line trace view (3) - #36058
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMay 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR generates a new metainfo.ts for protocol methods and centralizes call‐title rendering via a new renderTitleForCall helper, updating usages across the codebase and adjusting tests/UI to match.
- Added generation of
packages/protocol/src/metainfo.ts - Replaced inline
formatProtocolParamlogic withrenderTitleForCallin core modules - Updated tests and the trace viewer UI to use new method‐based titles
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/generate_channels.js | Invoke writeFile to emit the new metainfo.ts |
| tests/playwright-test/playwright.trace.spec.ts | Tests updated to use method instead of title |
| tests/library/tracing.spec.ts | Adjusted parsing helpers and assertions for actions |
| tests/library/trace-viewer.spec.ts | Updated all uppercase action selectors to proper case |
| tests/config/utils.ts | Switched actions generation to use renderTitleForCall |
| packages/trace-viewer/src/ui/actionList.tsx | UI now uses renderTitleForCall over inline parsing |
| packages/protocol/src/metainfo.ts | Generated map of method metadata and titles |
| packages/playwright/src/index.ts | Replaced protocol‐param formatting with renderTitleForCall |
| packages/playwright-core/src/server/recorder/recorderUtils.ts | Use renderTitleForCall for call logs |
| packages/playwright-core/src/server/page.ts | Log messages now use renderTitleForCall |
| packages/playwright-core/src/server/frames.ts | Frame progress logs updated to renderTitleForCall |
| packages/playwright-core/src/server/dispatchers/dispatcher.ts | Removed redundant formatting helper |
| packages/playwright-core/src/protocol/formatter.ts | Exposed renderTitleForCall helper |
Comments suppressed due to low confidence (3)
tests/library/tracing.spec.ts:741
- [nitpick] The test assertion for 'Evaluate' was removed, reducing coverage for formatted trace output; consider reintroducing a check to ensure the Evaluate title appears as expected.
expect(content).toContain('Evaluate');
tests/library/tracing.spec.ts:823
- [nitpick] Removed expectations on action titles in the sanitized call metadata; this may miss regressions in title formatting—add assertions back for title handling.
title: 'Evaluate'
packages/trace-viewer/src/ui/actionList.tsx:132
- renderTitleForCall is used here but not imported; add
import { renderTitleForCall } from '…/protocol/formatter';(or the correct module) at the top.
const { elements, title } = renderTitleForCall(action);
Yury Semikhatsky (yury-s)
approved these changes
May 22, 2025
| function highlightQuotedText(text: string): React.ReactNode[] { | ||
| const result: React.ReactNode[] = []; | ||
| function formatProtocolParam(params: Record<string, string> | undefined, name: string): string { |
There was a problem hiding this comment.
Let's reuse the one in formatter.ts?
MemberAuthor
There was a problem hiding this comment.
I can try making it isomorphic. Non-trivial due to the dependency on metainfo. Let me think about it.
| return deepParam(params, name); | ||
| } | ||
| function deepParam(params: Record<string, any>, name: string): string { |
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)force-pushed
the
2line_trace_3
branch
from
May 23, 2025 00:00
c2d26aa to
3b5aea1CompareYury Semikhatsky (yury-s)
approved these changes
May 23, 2025
Contributor
Test results for "tests 1"3 failed 4 flaky39212 passed, 804 skipped Merge workflow run. |
Nanne (whazor) pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.