Uh oh!
There was an error while loading. Please reload this page.
chore(cli): make skill discoverable from --help - #40274
Merged
Merged
Conversation
Commander was intercepting --help on the hidden 'cli' subcommand and printing its own help, never reaching cliProgram. Disable commander's built-in help handling for this subcommand.
Show the relative path to the SKILL.md bundled with playwright-core when users run 'playwright cli' with no command or '--help', so agents running the CLI can discover the skill file.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| console.log(command.help); | ||
| } else { | ||
| console.log('playwright-cli - run playwright mcp commands from terminal\n'); | ||
| console.log(`Agent skill: ${path.relative(process.cwd(), libPath('tools', 'cli-client', 'skill', 'SKILL.md'))}\n`); |
There was a problem hiding this comment.
I don't think we should be sending the user to a relative path to the npm cache folder for skills? Rather should recommend running install --skills?
Simon Knott (Skn0tt)
commented
Apr 20, 2026
ContributorAuthor
discussed again, let's land under AGENT env var |
Addresses review feedback on microsoft#40274.
Dmitry Gozman (dgozman)
approved these changes
Apr 21, 2026
Comment on lines
+199
to
+210
| export function guessClientName(): string { | ||
| if (process.env.CLAUDECODE) | ||
| return 'Claude Code'; | ||
| if (process.env.COPILOT_CLI) | ||
| return 'GitHub Copilot'; | ||
| return 'playwright-cli'; | ||
| } | ||
| export function isCodingAgent(): boolean { | ||
| return !!process.env.CLAUDECODE || !!process.env.COPILOT_CLI; | ||
| } | ||
Collaborator
There was a problem hiding this comment.
This seems absolutely unrelated to the registry!
Addresses review feedback on microsoft#40274.
# Conflicts: # packages/playwright-core/src/tools/cli-client/program.ts
Contributor
Test results for "MCP"3 failed 6457 passed, 976 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky39245 passed, 847 skipped Merge workflow run. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.