Skip to content

feat(dashboard): flatten browser/context into per-context attached pages - #40333

Merged
Pavel Feldman (pavelfeldman) merged 4 commits into
microsoft:mainfrom
Skn0tt:refactor-dashboard-attached-page
Apr 21, 2026
Merged

feat(dashboard): flatten browser/context into per-context attached pages#40333
Pavel Feldman (pavelfeldman) merged 4 commits into
microsoft:mainfrom
Skn0tt:refactor-dashboard-attached-page

Conversation

@Skn0tt

@Skn0ttSimon Knott (Skn0tt) commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Refactor extracted from feat(browser): browser.on(context) #40315 (the browser.on('context') event will follow in a separate PR).
  • AttachedBrowser → AttachedPage; BrowserSlot slimmed to { browser, descriptor, contextListeners }.
  • Sidebar renders one row per (session, context).
  • selectTab/newTab/closeTab gain a context field.

@Skn0tt
feat(dashboard): flatten browser/context into per-context attached pages
7aa6e41
Pavel suggested removing the browser/context split since multiple
contexts in one browser should not look different in the UI.
- AttachedBrowser becomes AttachedPage (one per attached page)
- BrowserSlot slimmed to { browser, descriptor, contextListeners }
- selectTab/newTab/closeTab gain a context field
- sidebar renders one row per (session, context)
@Skn0tt
test(dashboard): show one row per context for a single browser
4165945
@Skn0tt
refactor(dashboard): browserId takes api.Browser, drop slot from _wir…
01283bf
…eContext
@Skn0tt
test(dashboard): show placeholder chip for browser with no contexts
46c9e9d
@github-actions

github-actionsBot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

6 failed
❌ [firefox] › mcp/dashboard.spec.ts:67 › should show current workspace sessions first @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:119 › daemon show: closing page exits the process @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:159 › should capture annotations via show --annotate @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:180 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:202 › should pick locator from browser @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:267 › screenshot writes PNG bytes to the chosen file @mcp-windows-latest

6543 passed, 913 skipped

Merge workflow run.

@github-actions

github-actionsBot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`

39308 passed, 847 skipped

Merge workflow run.

@Skn0ttSimon Knott (Skn0tt) mentioned this pull request Apr 21, 2026
Merged
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 119e987 into microsoft:mainApr 21, 2026
37 of 38 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes
@dgozmanDmitry Gozman (dgozman)Awaiting requested review from dgozman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt@pavelfeldman