') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(test-runner): add {testFileBaseName} token to snapshotPathTemplate by devareddy05 · Pull Request #40466 · microsoft/playwright · GitHub
Skip to content

feat(test-runner): add {testFileBaseName} token to snapshotPathTemplate - #40466

Merged
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
devareddy05:feat-24171
May 4, 2026
Merged

feat(test-runner): add {testFileBaseName} token to snapshotPathTemplate#40466
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
devareddy05:feat-24171

Conversation

@devareddy05

@devareddy05Devendra Reddy Pennabadi (devareddy05) commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new {testFileBaseName} token to snapshotPathTemplate, expanding to the test file name without its last extension (matches path.parse().name).
  • Sample: for a test file page/page-click.spec.ts, {testFileBaseName} resolves to page-click.spec. The existing {testFileName} keeps producing page-click.spec.ts.
  • Useful on Windows where a test file 01-render.test.ts and a sibling snapshot folder of the same name collide; users can now write {testFileDir}/{testFileBaseName}-snapshots/{arg}{ext} to drop the trailing extension.
  • Extended the existing tokens should expand property test in snapshot-path-template.spec.ts rather than adding a new test.

Fixes#24171

Closed
@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:395 › should copy network request @windows-latest-node20

15 flaky⚠️ [installation tests] › connect-to-selenium.spec.ts:20 › connect to selenium `@package-installations-ubuntu-latest`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:449 › should be able to connect via localhost `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:433 › should work behind reverse proxy `@windows-latest-node20`

41463 passed, 847 skipped

Merge workflow run.

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [chromium] › mcp/dashboard.spec.ts:347 › save recording streams WebM bytes to the chosen file @mcp-windows-latest
❌ [firefox] › mcp/cli-devtools.spec.ts:204 › video-start-stop @mcp-windows-latest
❌ [firefox] › mcp/cli-devtools.spec.ts:218 › video-chapter @mcp-windows-latest
❌ [chrome] › mcp/mouse.spec.ts:69 › browser_mouse_click_xy (default) @mcp-macos-latest
❌ [webkit] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-macos-latest

6803 passed, 927 skipped

Merge workflow run.

@devareddy05

Devendra Reddy Pennabadi (devareddy05) commented May 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Test results for "MCP"

5 failed ❌ [chromium] › mcp/dashboard.spec.ts:347 › save recording streams WebM bytes to the chosen file @mcp-windows-latest ❌ [firefox] › mcp/cli-devtools.spec.ts:204 › video-start-stop @mcp-windows-latest ❌ [firefox] › mcp/cli-devtools.spec.ts:218 › video-chapter @mcp-windows-latest ❌ [chrome] › mcp/mouse.spec.ts:69 › browser_mouse_click_xy (default) @mcp-macos-latest ❌ [webkit] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-macos-latest

6803 passed, 927 skipped

Merge workflow run.

Hi maintainers Simon Knott (@Skn0tt) and Dmitry Gozman (@dgozman)

I believe the Chromium failure might be flaky, it’s been passing consistently in my local setup without issues.

Happy to add a changeset, rebase, or make any adjustments as needed. Thanks for taking a look!

@Skn0tt
Simon Knott (Skn0tt) merged commit cd3a044 into microsoft:mainMay 4, 2026
34 of 38 checks passed
This was referenced May 4, 2026
Closed
Closed
Closed
@YusukeIwakiYusuke Iwaki (YusukeIwaki) mentioned this pull request May 17, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Skn0ttSimon Knott (Skn0tt)Skn0tt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Add testFilePathName to snapshotPathTemplate (without extension)

2 participants

@devareddy05@Skn0tt