fix(mcp): propagate abort signal to stop test execution by mxschmitt · Pull Request #40582 · microsoft/playwright

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Max Schmitt (mxschmitt) · 2026-05-02T23:45:54Z

Summary

Propagate AbortSignal from MCP SDK through TestServerBackend → tool handlers → TestContext
Serialize test operations via a promise queue to prevent race conditions when abort is followed by an immediate new run
On abort, call runner.stopTests() and run global teardown before releasing the queue

Fixes#38937

Pavel Feldman (pavelfeldman) · 2026-05-05T17:36:25Z


+ private _enqueue<T>(fn: () => Promise<T>): Promise<T> {
+ const result = this._testOpQueue.then(fn);
+ this._testOpQueue = result.then(() => {}, () => {});


This will catch all the errors silently.

Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.

Fixesmicrosoft#38937

Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

Max Schmitt (mxschmitt) · 2026-05-05T19:56:07Z

Windows CI failures are pre-existing and unrelated to this PR — dashboard.spec.ts annotate tests are also failing on main: https://github.com/microsoft/playwright/actions/runs/25396744541/job/74485425551

- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

github-actions · 2026-05-06T09:13:01Z

Test results for "MCP"

12 failed
❌ [firefox] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/tracing.spec.ts:21 › check that trace is saved with browser_start_tracing @mcp-windows-latest-firefox
❌ [msedge] › mcp/test-run.spec.ts:126 › test_run should stop when aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:332 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:410 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-webkit
❌ [webkit] › mcp/dashboard.spec.ts:499 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-webkit

6944 passed, 1052 skipped

Merge workflow run.

github-actions · 2026-05-06T09:26:51Z

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

41661 passed, 851 skipped

Merge workflow run.

Pavel Feldman (pavelfeldman) reviewed May 5, 2026
View reviewed changes

fix(mcp): propagate abort signal to stop test execution
1a380e8
Fixesmicrosoft#38937

Max Schmitt (mxschmitt)force-pushed the mxschmitt/fix-38937 branch from 46b0543 to 1a380e8Compare May 5, 2026 18:26

fix(mcp): switch _enqueue to TestRunner queue pattern
1f0c0ce
Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.

This comment has been minimized.
Sign in to view

Pavel Feldman (pavelfeldman) reviewed May 6, 2026
View reviewed changes

Comment threadpackages/playwright/src/mcp/test/testContext.ts Outdated
Comment threadpackages/playwright/src/mcp/test/testContext.ts Outdated

fix(mcp): address review feedback
06d6c3a
- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise

Pavel Feldman (pavelfeldman) approved these changes May 6, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) merged commit a1f668d into microsoft:mainMay 6, 2026
41 of 45 checks passed

This was referenced May 6, 2026
[Ports]: Backport client side changes for 1.60 microsoft/playwright-python#3043
Closed
[Ports]: Backport client side changes for 1.60 microsoft/playwright-java#1902
Closed
[Ports]: Backport client side changes for 1.60 microsoft/playwright-dotnet#3293
Closed

This was referenced May 7, 2026
[ca] chore: update CLI versions (Claude Code 2.1.132, Copilot CLI 1.0.43, Playwright MCP 0.0.74) github/gh-aw#30783
Closed
Upstream updates detected — 2026-04-06 impravin22/my-claude-maestro#1
Closed

Simon Knott (Skn0tt) mentioned this pull request May 7, 2026
fix(mcp): prevent unhandled rejection in test op queue #40698
Merged

Yusuke Iwaki (YusukeIwaki) mentioned this pull request May 17, 2026
Update Playwright driver to 1.60.0 YusukeIwaki/playwright-ruby-client#380
Merged