chore: throw on Frame.expect / Page.expectScreenshot failure by dgozman · Pull Request #40801 · microsoft/playwright

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

Dmitry Gozman (dgozman) · 2026-05-12T13:32:45Z

Summary

Frame.expect and Page.expectScreenshot throw on failure instead of returning the diff payload. Failure details ride on a new per-method errorDetails: block in protocol.yml; the dispatcher always sends errorDetails (validated against the schema, defaulting to {}) for any method that defines one, so its presence on the wire is the matcher-error discriminator.
The unused noAutoWaiting option on Frame.expect is gone, which lets the one-shot/retry blocks stop threading the wrapper error through internal catches.
Server emits bare messages; the client uniformly prefixes Error: when surfacing them as errorMessage. YAML parse errors and JS-error/strict-mode messages now end up with the same shape inside the matcher's failure header.

Frame.expect and Page.expectScreenshot now throw on mismatch with strongly-typed errorDetails on the wire instead of returning a result object. Frame.expect no longer carries a protocol return value; failure details (received, timedOut, customErrorMessage) travel in a FrameExpectErrorDetails payload next to the response error, and the client rebuilds the matcher's ExpectResult from the rejected PlaywrightError.

Page.expectScreenshot throws a fixed 'Expect failed' placeholder and puts the human-readable text in errorDetails.customErrorMessage, so the matcher's errorMessage no longer picks up the apiName prefix and call log from the wire error.

Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

github-actions · 2026-06-05T08:54:52Z

Test results for "MCP"

7263 passed, 1109 skipped

Merge workflow run.

github-actions · 2026-06-05T09:02:31Z

Test results for "tests 1"

3 flaky

⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39548 passed, 771 skipped

Merge workflow run.

- Bump CLI_VERSION, version.rb, and the CircleCI Playwright server image to 1.61.1 - Regenerate development/api.json and documentation from the 1.61.1 driver (introduces Credentials and WebStorage classes; connectOverCDP artifactsDir) - Port Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash. - Update evaluate/evaluate_handle documentation example mappings to the revised upstream samples (microsoft/playwright#41002)

Ports Frame#expect to the 1.61 expect protocol: the command now resolves on a successful match and rejects with FrameExpectErrorDetails on mismatch/timeout (upstream microsoft/playwright#40801). Carry errorDetails on Playwright::Error and translate it back into the assertion result hash.

This comment has been minimized.
Sign in to view

Pavel Feldman (pavelfeldman) reviewed May 13, 2026
View reviewed changes

Comment threadpackages/playwright-core/src/client/frame.ts

Pavel Feldman (pavelfeldman) reviewed May 13, 2026
View reviewed changes

Comment threadpackages/playwright-core/src/client/frame.ts

Pavel Feldman (pavelfeldman) reviewed May 13, 2026
View reviewed changes

Comment threadpackages/playwright-core/src/client/page.ts

Pavel Feldman (pavelfeldman) reviewed May 13, 2026
View reviewed changes

Comment threadpackages/protocol/spec/frame.yml Outdated

Pavel Feldman (pavelfeldman) approved these changes May 14, 2026
View reviewed changes

Dmitry Gozman (dgozman)force-pushed the chore-expect-throws branch from 2859430 to e181e0fCompare May 18, 2026 15:07

This comment has been minimized.
Sign in to view

Pavel Feldman (pavelfeldman) approved these changes May 21, 2026
View reviewed changes

Dmitry Gozman (dgozman) added 2 commits June 4, 2026 15:48

Dmitry Gozman (dgozman)force-pushed the chore-expect-throws branch from 19c0ee7 to 5b856d7Compare June 4, 2026 14:50

This comment has been minimized.
Sign in to view

chore(expect): always carry typed error details across the wire
ffd89ea
Validate ErrorDetails unconditionally on the client (with {} fallback) and wrap expectScreenshot pre-check failures so they surface as typed matcher errors instead of escaping as raw rejections.

Dmitry Gozman (dgozman)force-pushed the chore-expect-throws branch from 5b856d7 to ffd89eaCompare June 5, 2026 08:18

Dmitry Gozman (dgozman) merged commit 7cc4a85 into microsoft:mainJun 5, 2026
46 checks passed

This was referenced Jun 5, 2026
[Ports]: Backport client side changes for 1.61 microsoft/playwright-python#3070
Closed
[Ports]: Backport client side changes for 1.61 microsoft/playwright-java#1917
Closed
[Ports]: Backport client side changes for 1.61 microsoft/playwright-dotnet#3312
Closed

Dmitry Gozman (dgozman) mentioned this pull request Jun 12, 2026
chore: roll driver to 1.62.0-alpha-1781285727000 microsoft/playwright-dotnet#3323
Merged

Yury Semikhatsky (yury-s) mentioned this pull request Jun 12, 2026
chore: roll driver to 1.61.0-beta-1781285686000 microsoft/playwright-java#1929
Merged

Kurt Ruppel (kruppel) mentioned this pull request Jun 26, 2026
Upgrade to Playwright 1.61.1 kruppel/playwright-ruby-client#1
Closed

Kurt Ruppel (kruppel) mentioned this pull request Jun 26, 2026
Upgrade to Playwright 1.61.1 YusukeIwaki/playwright-ruby-client#381
Merged