Uh oh!
There was an error while loading. Please reload this page.
fix(mcp): report missing ffmpeg distinctly from missing browser - #40867
Conversation
The MCP launch error handler was rewriting any `Executable doesn't exist` error into `Browser "<channel>" is not installed`, but the registry uses the same prefix for ffmpeg too. When `recordVideo` was enabled and ffmpeg was missing, users were told to install a browser that was already there. Disambiguate the rewrite by the executable path so ffmpeg gets its own message pointing at `install-browser ffmpeg`. Fixes: microsoft#40862
Test results for "MCP"9 failed 7094 passed, 1113 skipped Merge workflow run. |
23edf71
into
microsoft:mainUh oh!
There was an error while loading. Please reload this page.
…stalled (#41941) when a browser binary is missing, `throwIfExecutableMissing` caught playwright-core's `Executable doesn't exist at <path>` and rethrew a generic `Browser "<name>" is not installed`, dropping the path that path holds the version-specific directory (e.g. `firefox-1534`), which is what tells a genuinely missing install apart from a version mismatch browsers from a standalone `playwright install` land in a differently-versioned directory than the bundled `playwright-core` expects keep the path in the rethrown message so the mismatch is diagnosable this is a further improvement for <#40867> referenced in <#41871>
Summary
Executable doesn't existerror intoBrowser "<channel>" is not installed, but the registry uses the same prefix for ffmpeg. WithrecordVideoenabled and ffmpeg missing, users were told to install a browser that was already there.install-browser ffmpeg.Fixes#40862