Uh oh!
There was an error while loading. Please reload this page.
fix(expect): render expect error aria snapshot lazily on final failure - #41117
fix(expect): render expect error aria snapshot lazily on final failure#41117Yury Semikhatsky (yury-s) wants to merge 2 commits into
Conversation
Previously `InjectedScript.expect()` rendered an aria snapshot on every poll attempt so a failure message would be ready. For a hidden or missing element this renders a full-page snapshot of `document.body`, so when many auto-retrying assertions poll concurrently while their targets are hidden, every poll of every assertion renders the full page, saturating the page main thread - which in turn delays whatever reveals the elements, making the assertions poll even longer. Render the snapshot once, lazily, when the assertion reaches its final failure. Fixes: microsoft#41098
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… hint Render the error-context aria snapshot during polling (capturing the exact state at the point of failure, as before microsoft#41098), but only on the last poll(s) before the deadline instead of on every poll. retryWithProgressAndBackoff now passes a `lastAttempt` hint to its callback, computed from the deadline and the backoff schedule: it is true once fewer than two steady-state intervals remain. Using a small window of attempts rather than a single predicted one keeps this reliable - an earlier attempt in the window still completes and stores its snapshot even if the very last attempt is aborted by the deadline. Assertions that pass before that window (the common case) never render a snapshot, so concurrent auto-retrying assertions no longer saturate the page.
Test results for "MCP"7230 passed, 1103 skipped Merge workflow run. |
Test results for "tests 1"19 failed 3 flaky39547 passed, 771 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
left a comment
There was a problem hiding this comment.
There is no last attempt when the test times out.
Summary
InjectedScript.expect()rendered an aria snapshot on every poll attempt; for a hidden/missing element this renders a full-page snapshot. When many auto-retrying assertions poll concurrently while their targets are hidden, every poll of every assertion renders the full page, saturating the page main thread — which delays whatever reveals the elements, making the assertions poll even longer.Fixes#41098