chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitry Gozman (dgozman) merged 1 commit into from
Jun 12, 2026
Merged

chore: fixes uncovered by the .NET 1.61 roll #41266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions docs/src/api/class-credentials.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
- `privateKey` <[string]>
- `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down
11 changes: 6 additions & 5 deletions docs/src/api/class-webstorage.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
* alias: WebStorageItem
- `name` <[string]>
- `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down
44 changes: 28 additions & 16 deletions packages/playwright-client/types/types.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
/**
* Seeds a virtual WebAuthn credential and returns it.
*
* With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
* is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
* flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
* in a later test.
* With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
* fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
* the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
* the private and public keys, so it can be persisted to disk and re-seeded in a later test.
*
* To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
* To **import a known credential**, supply all four of
* [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
* [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
* [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
* [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
*
* Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
* navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
delete(id: string): Promise<void>;

/**
* Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
* both credentials seeded with
* Returns every credential currently held by the authenticator, optionally filtered by
* [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
* [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
* seeded with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
* credentials the page registered itself by calling `navigator.credentials.create()`.
*
* Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
* saved and re-seeded into a later test with
* Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
* and re-seeded into a later test with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
* the second example in the class overview.
* @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
* `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
* `navigator.credentials`.
*
* Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
* absent) WebAuthn behaviour. Seeding credentials with
* Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
* called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
* credentials with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
* `install()` populates the authenticator, but the page will never see those credentials.
* installing populates the authenticator, but the page will never see those credentials.
*/
install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
clear(): Promise<void>;

/**
* Returns the value for the given `name`, or `null` if the key is not present.
* Returns the value for the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
* @param name Name of the item to retrieve.
*/
getItem(name: string): Promise<null|string>;

/**
* Returns all items in the storage as `name`/`value` pairs.
* Returns all items in the storage as name/value pairs.
*/
items(): Promise<Array<{
name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
}>>;

/**
* Removes the item with the given `name`. No-op if the item is absent.
* Removes the item with the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
* is absent.
* @param name Name of the item to remove.
*/
removeItem(name: string): Promise<void>;

/**
* Sets the value for the given `name`. Overwrites any existing value for that name.
* Sets the value for the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
* existing value for that name.
* @param name Name of the item to set.
* @param value New value for the item.
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/trace/recorder/snapshotter.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

async reset() {
if (this._started)
await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
}

stop() {
Expand Down
44 changes: 28 additions & 16 deletions packages/playwright-core/types/types.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
/**
* Seeds a virtual WebAuthn credential and returns it.
*
* With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
* is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
* flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
* in a later test.
* With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
* fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
* the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
* the private and public keys, so it can be persisted to disk and re-seeded in a later test.
*
* To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
* To **import a known credential**, supply all four of
* [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
* [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
* [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
* [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
*
* Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
* navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
delete(id: string): Promise<void>;

/**
* Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
* both credentials seeded with
* Returns every credential currently held by the authenticator, optionally filtered by
* [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
* [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
* seeded with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
* credentials the page registered itself by calling `navigator.credentials.create()`.
*
* Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
* saved and re-seeded into a later test with
* Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
* and re-seeded into a later test with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
* the second example in the class overview.
* @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
* `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
* `navigator.credentials`.
*
* Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
* absent) WebAuthn behaviour. Seeding credentials with
* Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
* called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
* credentials with
* [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
* `install()` populates the authenticator, but the page will never see those credentials.
* installing populates the authenticator, but the page will never see those credentials.
*/
install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
clear(): Promise<void>;

/**
* Returns the value for the given `name`, or `null` if the key is not present.
* Returns the value for the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
* @param name Name of the item to retrieve.
*/
getItem(name: string): Promise<null|string>;

/**
* Returns all items in the storage as `name`/`value` pairs.
* Returns all items in the storage as name/value pairs.
*/
items(): Promise<Array<{
name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
}>>;

/**
* Removes the item with the given `name`. No-op if the item is absent.
* Removes the item with the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
* is absent.
* @param name Name of the item to remove.
*/
removeItem(name: string): Promise<void>;

/**
* Sets the value for the given `name`. Overwrites any existing value for that name.
* Sets the value for the given
* [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
* existing value for that name.
* @param name Name of the item to set.
* @param value New value for the item.
*/
Expand Down
2 changes: 0 additions & 2 deletions packages/protocol/spec/electron.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
type: interface

extends: EventTarget

initializer:
context: BrowserContext

Expand Down
2 changes: 1 addition & 1 deletion packages/protocol/src/channels.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
_type_ElectronApplication: boolean;
browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down
20 changes: 20 additions & 0 deletions tests/library/trace-viewer.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
await context.tracing.start({ screenshots: true, snapshots: true });
await page.goto(server.EMPTY_PAGE);
await page.setContent('<button>Click</button>');

await context.tracing.startChunk();
await page.click('"Click"');
await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

await context.tracing.startChunk();
await page.hover('"Click"');
await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

// Snapshots in the second chunk must be self-contained and not reference
// snapshot state from the first chunk.
const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
const frame = await traceViewer.snapshotFrame('Hover');
await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
const traceViewer = await showTraceViewer(undefined, { stdin: true });
await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: fixes uncovered by the .NET 1.61 roll#41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Dmitry Gozman (dgozman)
merged 1 commit into

from

Jun 12, 2026
 Merged


chore: fixes uncovered by the .NET 1.61 roll
#41266
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 9 additions & 10 deletions
docs/src/api/class-credentials.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -281,9 +281,9 @@ Installs the virtual WebAuthn authenticator into the context, overriding
`navigator.credentials.create()` and `navigator.credentials.get()` in all current
and future pages. Call this before the page first touches `navigator.credentials`.

Required: until `install()` is called, no interception is in place and the page sees
Required: until [`method: Credentials.install`] is called, no interception is in place and the page sees
the platform's native (or absent) WebAuthn behaviour. Seeding credentials with
[`method: Credentials.create`] without `install()` populates the authenticator, but the
[`method: Credentials.create`] without installing populates the authenticator, but the
page will never see those credentials.

## async method: Credentials.create
Expand All@@ -298,13 +298,12 @@ page will never see those credentials.

Seeds a virtual WebAuthn credential and returns it.

With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
With only [`param: Credentials.create.rpId`], generates a fresh **ECDSA P-256** keypair, credential id and user handle. The
seeded credential is discoverable (resident), so the page can resolve it from both
username-then-passkey and usernameless passkey flows. The returned object carries the `privateKey` and `publicKey`, so
it can be persisted to disk and re-seeded in a later test.
username-then-passkey and usernameless passkey flows. The returned object carries the private and public keys, so it can be persisted to disk and re-seeded in a later test.

To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and
`publicKey` together.
To **import a known credential**, supply all four of [`option: Credentials.create.id`], [`option: Credentials.create.userHandle`], [`option: Credentials.create.privateKey`] and
[`option: Credentials.create.publicKey`] together.

Call [`method: Credentials.install`] before navigating to a page that uses WebAuthn.

Expand DownExpand Up@@ -361,11 +360,11 @@ Base64url-encoded credential id.
 - `privateKey` <[string]>
 - `publicKey` <[string]>

Returns every credential currently held by the authenticator, optionally filtered by `rpId` or
`id`. This includes both credentials seeded with [`method: Credentials.create`] and credentials
Returns every credential currently held by the authenticator, optionally filtered by [`option: Credentials.get.rpId`] or
[`option: Credentials.get.id`]. This includes both credentials seeded with [`method: Credentials.create`] and credentials
the page registered itself by calling `navigator.credentials.create()`.

Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just
Each returned credential includes its private and public keys, so a passkey the app just
registered can be saved and re-seeded into a later test with [`method: Credentials.create`] — see the second example in the class overview.

### option: Credentials.get.rpId
Expand Down

11 changes: 6 additions & 5 deletions
docs/src/api/class-webstorage.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ page.local_storage.clear()
page.navigate("https://example.com");
page.localStorage().setItem("token", "abc");
String token = page.localStorage().getItem("token");
List<NameValue> all = page.localStorage().items();
List<WebStorageItem> all = page.localStorage().items();
page.localStorage().removeItem("token");
page.localStorage().clear();
```
Expand All@@ -54,16 +54,17 @@ await page.LocalStorage.ClearAsync();
## async method: WebStorage.items
* since: v1.61
- returns: <[Array]<[Object]>>
 * alias: WebStorageItem
 - `name` <[string]>
 - `value` <[string]>

Returns all items in the storage as `name`/`value` pairs.
Returns all items in the storage as name/value pairs.

## async method: WebStorage.getItem
* since: v1.61
- returns: <[null]|[string]>

Returns the value for the given `name`, or `null` if the key is not present.
Returns the value for the given [`param: WebStorage.getItem.name`] if present.

### param: WebStorage.getItem.name
* since: v1.61
Expand All@@ -74,7 +75,7 @@ Name of the item to retrieve.
## async method: WebStorage.setItem
* since: v1.61

Sets the value for the given `name`. Overwrites any existing value for that name.
Sets the value for the given [`param: WebStorage.setItem.name`]. Overwrites any existing value for that name.

### param: WebStorage.setItem.name
* since: v1.61
Expand All@@ -91,7 +92,7 @@ New value for the item.
## async method: WebStorage.removeItem
* since: v1.61

Removes the item with the given `name`. No-op if the item is absent.
Removes the item with the given [`param: WebStorage.removeItem.name`]. No-op if the item is absent.

### param: WebStorage.removeItem.name
* since: v1.61
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-client/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 1 addition & 1 deletion
packages/playwright-core/src/server/trace/recorder/snapshotter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class Snapshotter {

 async reset() {
 if (this._started)
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].reset()`, 'main');
 await this._context.safeNonStallingEvaluateInAllFrames(`window["${this._snapshotStreamer}"].resetHistory()`, 'main');
 }

 stop() {
Expand Down

44 changes: 28 additions & 16 deletions
packages/playwright-core/types/types.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18867,12 +18867,16 @@ export interface Credentials {
 /**
 * Seeds a virtual WebAuthn credential and returns it.
 *
 * With only `rpId`, generates a fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential
 * is discoverable (resident), so the page can resolve it from both username-then-passkey and usernameless passkey
 * flows. The returned object carries the `privateKey` and `publicKey`, so it can be persisted to disk and re-seeded
 * in a later test.
 * With only [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-rp-id), generates a
 * fresh **ECDSA P-256** keypair, credential id and user handle. The seeded credential is discoverable (resident), so
 * the page can resolve it from both username-then-passkey and usernameless passkey flows. The returned object carries
 * the private and public keys, so it can be persisted to disk and re-seeded in a later test.
 *
 * To **import a known credential**, supply all four of `id`, `userHandle`, `privateKey` and `publicKey` together.
 * To **import a known credential**, supply all four of
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-id),
 * [`userHandle`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-user-handle),
 * [`privateKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-private-key) and
 * [`publicKey`](https://playwright.dev/docs/api/class-credentials#credentials-create-option-public-key) together.
 *
 * Call [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) before
 * navigating to a page that uses WebAuthn.
Expand DownExpand Up@@ -18935,13 +18939,15 @@ export interface Credentials {
 delete(id: string): Promise<void>;

 /**
 * Returns every credential currently held by the authenticator, optionally filtered by `rpId` or `id`. This includes
 * both credentials seeded with
 * Returns every credential currently held by the authenticator, optionally filtered by
 * [`rpId`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-rp-id) or
 * [`id`](https://playwright.dev/docs/api/class-credentials#credentials-get-option-id). This includes both credentials
 * seeded with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) and
 * credentials the page registered itself by calling `navigator.credentials.create()`.
 *
 * Each returned credential includes its `privateKey` and `publicKey`, so a passkey the app just registered can be
 * saved and re-seeded into a later test with
 * Each returned credential includes its private and public keys, so a passkey the app just registered can be saved
 * and re-seeded into a later test with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) — see
 * the second example in the class overview.
 * @param options
Expand DownExpand Up@@ -18973,10 +18979,11 @@ export interface Credentials {
 * `navigator.credentials.get()` in all current and future pages. Call this before the page first touches
 * `navigator.credentials`.
 *
 * Required: until `install()` is called, no interception is in place and the page sees the platform's native (or
 * absent) WebAuthn behaviour. Seeding credentials with
 * Required: until [credentials.install()](https://playwright.dev/docs/api/class-credentials#credentials-install) is
 * called, no interception is in place and the page sees the platform's native (or absent) WebAuthn behaviour. Seeding
 * credentials with
 * [credentials.create(rpId[, options])](https://playwright.dev/docs/api/class-credentials#credentials-create) without
 * `install()` populates the authenticator, but the page will never see those credentials.
 * installing populates the authenticator, but the page will never see those credentials.
 */
 install(): Promise<void>;
}
Expand DownExpand Up@@ -21677,13 +21684,14 @@ export interface WebStorage {
 clear(): Promise<void>;

 /**
 * Returns the value for the given `name`, or `null` if the key is not present.
 * Returns the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-get-item-option-name) if present.
 * @param name Name of the item to retrieve.
 */
 getItem(name: string): Promise<null|string>;

 /**
 * Returns all items in the storage as `name`/`value` pairs.
 * Returns all items in the storage as name/value pairs.
 */
 items(): Promise<Array<{
 name: string;
Expand All@@ -21692,13 +21700,17 @@ export interface WebStorage {
 }>>;

 /**
 * Removes the item with the given `name`. No-op if the item is absent.
 * Removes the item with the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-remove-item-option-name). No-op if the item
 * is absent.
 * @param name Name of the item to remove.
 */
 removeItem(name: string): Promise<void>;

 /**
 * Sets the value for the given `name`. Overwrites any existing value for that name.
 * Sets the value for the given
 * [`name`](https://playwright.dev/docs/api/class-webstorage#web-storage-set-item-option-name). Overwrites any
 * existing value for that name.
 * @param name Name of the item to set.
 * @param value New value for the item.
 */
Expand Down

2 changes: 0 additions & 2 deletions
packages/protocol/spec/electron.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,6 @@ Electron:
ElectronApplication:
 type: interface

 extends: EventTarget

 initializer:
 context: BrowserContext

Expand Down

2 changes: 1 addition & 1 deletion
packages/protocol/src/channels.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2237,7 +2237,7 @@ export interface ElectronApplicationEventTarget {
 on(event: 'close', callback: (params: ElectronApplicationCloseEvent) => void): this;
 on(event: 'console', callback: (params: ElectronApplicationConsoleEvent) => void): this;
}
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, EventTargetChannel {
export interface ElectronApplicationChannel extends ElectronApplicationEventTarget, Channel {
 _type_ElectronApplication: boolean;
 browserWindow(params: ElectronApplicationBrowserWindowParams, progress?: Progress): Promise<ElectronApplicationBrowserWindowResult>;
 evaluateExpression(params: ElectronApplicationEvaluateExpressionParams, progress?: Progress): Promise<ElectronApplicationEvaluateExpressionResult>;
Expand Down

20 changes: 20 additions & 0 deletions
tests/library/trace-viewer.spec.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2507,6 +2507,26 @@ test('should capture iframe with srcdoc', async ({ page, server, runAndTrace })
 await expect(frame.frameLocator('iframe').getByRole('button')).toHaveText('Hello iframe');
});

test('should render snapshots from the second chunk', async ({ context, page, server, showTraceViewer }, testInfo) => {
 await context.tracing.start({ screenshots: true, snapshots: true });
 await page.goto(server.EMPTY_PAGE);
 await page.setContent('<button>Click</button>');

 await context.tracing.startChunk();
 await page.click('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace1.zip') });

 await context.tracing.startChunk();
 await page.hover('"Click"');
 await context.tracing.stopChunk({ path: testInfo.outputPath('trace2.zip') });

 // Snapshots in the second chunk must be self-contained and not reference
 // snapshot state from the first chunk.
 const traceViewer = await showTraceViewer(testInfo.outputPath('trace2.zip'));
 const frame = await traceViewer.snapshotFrame('Hover');
 await expect(frame.locator('button')).toHaveText('Click');
});

test('take trace paths via stdin', async ({ showTraceViewer }) => {
 const traceViewer = await showTraceViewer(undefined, { stdin: true });
 await expect(traceViewer.page).toHaveTitle('Playwright Trace Viewer');
Expand Down
Loading