Skip to content

fix(transform): detect partially written compilation cache entries - #41739

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:cache-sha1-header
Jul 10, 2026
Merged

fix(transform): detect partially written compilation cache entries#41739
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:cache-sha1-header

Conversation

@pavelfeldman

@pavelfeldmanPavel Feldman (pavelfeldman) commented Jul 10, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Store cached transpiled code as // <sha1>\n<content> and verify the hash when reading.
  • A partially written or corrupted cache entry is now ignored and re-transpiled instead of being used.

Fixes: #41726

@pavelfeldman
fix(transform): detect partially written compilation cache entries
bab26a6
Store cached transpiled code as `// <sha1>\n<content>` and verify the
hash when reading, so that a partially written cache file is ignored
and re-transpiled instead of being used.
@github-actions

github-actionsBot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [chromium] › mcp/annotate.spec.ts:497 › should disengage annotate mode when --annotate client disconnects @mcp-macos-latest-chromium
❌ [firefox] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:173 › user-initiated annotate downloads zip with feedback.md @mcp-macos-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:497 › should disengage annotate mode when --annotate client disconnects @mcp-macos-latest-firefox
❌ [webkit] › mcp/annotate.spec.ts:497 › should disengage annotate mode when --annotate client disconnects @mcp-macos-latest-webkit

7755 passed, 1249 skipped

Merge workflow run.

@github-actions

github-actionsBot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [firefox-library] › library/heap.spec.ts:223 › should not leak workers `@firefox-ubuntu-22.04-node20`

49521 passed, 1161 skipped

Merge workflow run.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit d448aac into microsoft:mainJul 10, 2026
45 of 48 checks passed
This was referenced Jul 15, 2026
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Non-deterministic crashes when loading config concurrently in ESM - Cannot add property metadata, object is not extensible

2 participants

@pavelfeldman@yury-s