Uh oh!
There was an error while loading. Please reload this page.
chore(expect): preserve _expect call shape - #41790
Merged
Simon Knott (Skn0tt) merged 1 commit intoJul 15, 2026
Merged
Conversation
Keep signal and timeout together in the existing options argument so external matcher integrations retain the two-argument _expect shape. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0fa14695-93a6-4bf6-b4d9-76499a0f91cf
Contributor
Test results for "MCP"1 failed 7759 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky49676 passed, 1156 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on Dima’s review comment by keeping
signalandtimeouttogether in_expect’s existing options object.Although
_expectisn’t documented, external matcher integrations rely on its two-argument shape:shotestcalls_expect(method, options)directly.mobilewrightimplements compatibleLocatorandFrame_expect(expression, options)hooks.Keeping
_expect(expression, options)avoids breaking those integrations while still keeping timeout and signal out of protocol params.