Skip to content

test: race between close() and navigation with RenderDocument - #42251

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-close-navigation-race
Aug 14, 2026
Merged

test: race between close() and navigation with RenderDocument#42251
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-close-navigation-race

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

References #42068.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`

51125 passed, 1214 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [chrome] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:269 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:291 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:316 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
❌ [firefox] › mcp/cli-json.spec.ts:220 › request and per-part commands return JSON result @mcp-windows-latest-firefox

8096 passed, 1311 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 CI is clear — the 5 failures are all pre-existing MCP flakes

This PR only adds one test to browsercontext-pages.spec.ts; none of the reported failures are in MCP-adjacent code, and every one of them flip-flops on unrelated SHAs across the test-results DB.

Details

Overall: the diff is a single new library test (should close page while a reload is committing), Chromium-fixme'd. The 5 failures are all in tests/mcp/, which this PR doesn't touch. Each is an established flake in the aggregated CI results (700+ runs), failing/rescued on many SHAs the PR can't be responsible for.

Pre-existing flake / infra

  • [chrome] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid@mcp-ubuntu-latest-chrome — flake: failed 6 / rescued 5 of 739 chrome runs, and flakes on chromium/firefox too. Unrelated to a browsercontext test.
  • [chrome] › mcp/annotate.spec.ts:269 › should start dashboard and annotate when no dashboard is running@mcp-windows-latest-chrome — flake: 0 outright failures but rescued in 3 of 739 chrome runs (retry-rescued elsewhere).
  • [chrome] › mcp/annotate.spec.ts:291 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate@mcp-windows-latest-chrome — flake: rescued in 2 of 739 chrome runs; the whole annotate.spec.ts file is broadly flaky.
  • [chrome] › mcp/annotate.spec.ts:316 › should annotate via direct browser_annotate MCP call@mcp-windows-latest-chrome — flake: rescued in 1 of 739 chrome runs, plus firefox failures on unrelated SHAs.
  • [firefox] › mcp/cli-json.spec.ts:220 › request and per-part commands return JSON result@mcp-windows-latest-firefox — flake: failed 2 / rescued 1 of 726 firefox runs (and 1 rescued of 739 on chrome), all on unrelated SHAs.

I'm a first pass, not the final word, but the diff has no path to the MCP suite and the history is unambiguous — this looks clear to merge on CI grounds.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit b8bd759 into microsoft:mainAug 14, 2026
42 of 45 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman@Skn0tt