Uh oh!
There was an error while loading. Please reload this page.
fix(web): make image diff mode switcher keyboard accessible - #42311
Merged
Conversation
The Diff / Actual / Expected / Side by side / Slider switchers were plain divs with no role or tabIndex, so they could not be reached or activated with the keyboard and were invisible to assistive tech. Render them as native buttons with role=tab and aria-selected in a tablist, following the approach of microsoft#41434. The focus ring falls back from the vscode theme variable to the html reporter one, since the component is shared between both. Fixes: microsoft#42266
Pavel Feldman (pavelfeldman)
approved these changes
Aug 19, 2026
Yury Semikhatsky (yury-s)
merged commit Aug 19, 2026
28b4fea
into
microsoft:main
29 of 43 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Test results for "MCP"Warning The triggering workflow run ended with status 6230 passed, 1040 skipped Merge workflow run. |
Contributor
Test results for "tests 1"Warning The triggering workflow run ended with status 7 flaky23591 passed, 583 skipped Merge workflow run. |
This was referenced Aug 20, 2026
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tabIndex— mouse-only and invisible to assistive tech. They now render as native<button role=tab aria-selected>in atablist, following feat(web): canonical keyboard traversal and focus rings #41434.all: unsetreset; the focus ring usesvar(--vscode-focusBorder, var(--color-accent-fg))since the component is shared between the trace viewer and the html reporter theme systems.Fixes#42266