Uh oh!
There was an error while loading. Please reload this page.
fix(recorder): support re-enabling recorder on the same context - #42383
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi, I'm the Playwright bot and I took a first look at the failing CI. 🟢 CI is clear — the one failure is a pre-existing flake
DetailsThis PR changes Pre-existing flake / infra
The 7 "flaky" entries in the Triaged by the Playwright bot - agent run |
269fd33 to
f9713c6CompareTest results for "tests 1"5 flaky51385 passed, 1238 skipped Merge workflow run. |
Uh oh!
There was an error while loading. Please reload this page.
Test results for "MCP"8142 passed, 1361 skipped Merge workflow run. |
Summary
RecorderApp.showis renamed toenableand now supports repeatedenableRecordercalls on the same context: at most one recorder app (inspector window or programmatic) is active per context, andparams.modeis applied explicitly sinceRecorder.forContextignores params of an existing recorder — enable after disable used to silently record nothing.ProgrammaticRecorderAppunsubscribes its recorder listeners on close,disableRecordernow closes the active app of either kind, so recording can be re-enabled in a different mode.Extracted from #42359.