Uh oh!
There was an error while loading. Please reload this page.
fix(chromium): restore automation launch flag - #42403
fix(chromium): restore automation launch flag#42403Devin Rousso (dcrousso) wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| const browser = await browserType.launch({ | ||
| tracesDir, | ||
| ...config.browser.launchOptions, | ||
| ...{ disableAutomation: true }, |
There was a problem hiding this comment.
You can use ignoreDefaultArgs option instead.
removing `--enable-automation` lets managed Edge hand off the browser process during SAML login restore the default flag while preserving MCP launch behavior with `ignoreDefaultArgs`
d674afb to
000f8afCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| '--unsafely-disable-devtools-self-xss-warnings', | ||
| // Edge can potentially restart on Windows (msRelaunchNoCompatLayer) which looses its file descriptors (stdout/stderr) and CDP (3/4). Disable until fixed upstream. | ||
| '--edge-skip-compat-layer-relaunch', | ||
| '--enable-automation', |
There was a problem hiding this comment.
It was removed in this change after some back and forth changes. The idea was that when browser is controlled via remote debugger, the same features are already turned on. --enable-automation is a big hammer and we haven't heard any complaints after removing the flag. Let's narrow down what is not working in their scenario and see if we can fix it differently.
There was a problem hiding this comment.
unless im misreading the code, that change always set --enable-automation unless assistantMode: true, which was only for MCP, meaning that --enable-automation was always on for all other cases
furthermore, it was unconditionally added and has been unconditionally set since b20e87d 7yrs ago
There was a problem hiding this comment.
as the original issue demonstrates, Chromium also uses --enable-automation to disable process handoff behavior https://issues.chromium.org/issues/371112535
Pavel Feldman (pavelfeldman)
commented
Aug 27, 2026
This likely has implications we don't want to deal with. |
Test results for "tests 1"3 flaky51299 passed, 1237 skipped Merge workflow run. |
Test results for "MCP"2 failed 8257 passed, 1361 skipped Merge workflow run. |
Hi, I'm the Playwright bot and I took a look at the failing CI on this PR. 🟢 The two failures are pre-existing flakes — this PR is clearBoth are Windows-only MCP flakes that fail on unrelated SHAs, and neither sits on a code path this PR changes. The diff adds DetailsLatest MCP run had 2 failed; latest "tests 1" run was flaky-only. Both failures reproduce on other PRs in the test-results DB. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
removing
--enable-automationlets managed Edge hand off the browser process during SAML loginrestore the default flag while preserving MCP launch behavior through an internal launch setting
regression from #40190
fixes#42379