Skip to content

chore(trace-viewer): only offer "Display Aria" when the trace has both snapshot kinds - #42435

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:aria-mode-setting
Aug 27, 2026
Merged

chore(trace-viewer): only offer "Display Aria" when the trace has both snapshot kinds#42435
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:aria-mode-setting

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • Disable the "Display Aria" setting when the trace has only DOM snapshots or only aria snapshots — there is nothing to switch between.
  • In that case the snapshot tab ignores the stored setting and displays whatever the trace has.

…h snapshot kinds
The setting is disabled when the trace has only DOM or only aria snapshots -
there is nothing to switch between. In that case the view ignores the stored
setting and displays whatever the trace actually has.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`

51314 passed, 1239 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/http.spec.ts:105 › http transport browser lifecycle (isolated) @mcp-ubuntu-latest-chromium

8258 passed, 1361 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a pre-existing flake

Hi, I'm the Playwright bot and I took a look at the failing CI. The single real failure is mcp/http.spec.ts:105 › http transport browser lifecycle (isolated) on chromium, and it's a known flake unrelated to this PR — which only touches trace-viewer UI.

Details

This PR (chore(trace-viewer): only offer "Display Aria" ...) changes trace-viewer React components and traceModel.ts. Nothing here touches the MCP HTTP transport or browser lifecycle.

Pre-existing flake / infra

Not real failures

  • [chromium-library] › library/video.spec.ts:736 › should work with video+trace and [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy — reported flaky (passed on retry), nothing to triage.

Net: no failure is attributable to this PR.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 267f5c6 into microsoft:mainAug 27, 2026
44 of 45 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman@dgozman