Skip to content

feat(webkit): roll to r2358 - #42438

Merged
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2358
Aug 28, 2026
Merged

feat(webkit): roll to r2358#42438
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2358

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/c5e3e92522104ce25a332d82880fe4fc815b3972. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [playwright-test] › ui-mode-test-update.spec.ts:202 › should update test locations `@ubuntu-latest-node24`

51327 passed, 1240 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/cli-parsing.spec.ts:67 › wrong argument type @mcp-macos-latest-chrome

8258 passed, 1361 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one real failure is a pre-existing Chrome flake

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

This PR only bumps the WebKit binary (browsers.json23552358). The single non-flaky failure is a Chrome MCP test that times out, on a code path this roll can't touch — and the same test timed out on an unrelated PR. Nothing here points back to this change.

Details

Overall: the "tests 1" run reported only 4 flaky tests (all passed on retry), and the "MCP" run had one real failure. None of it involves WebKit.

Pre-existing flake / infra

  • [chrome] › mcp/cli-parsing.spec.ts:67 › wrong argument type@mcp-macos-latest-chrome — pre-existing flake. Across the test-results DB this test failed 2 of 2218 chrome runs, both timedOut, and one of those was on PR fix(storageState): close IndexedDB connections opened by collect and restore #42260 (sha 5c903e14, 2026-08-14) — a run this WebKit roll can't be responsible for. It's a Chrome CLI-argument-parsing test; this PR ships nothing but a new WebKit revision, so it can't reach that path.

Flaky, not triaged (passed on retry, all unrelated to WebKit):

  • [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work
  • [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation
  • [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times
  • [playwright-test] › ui-mode-test-update.spec.ts:202 › should update test locations

If a WebKit test had failed, that'd be the interesting result — but none did. The roll looks clean from a CI standpoint.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) @chrome-macos-latest

23 flaky⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:28 › should connect to an existing cdp session `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:28 › context.cookies() should work Radoslav Kirilov (@smoke) `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/client-certificates.spec.ts:158 › fetch › should not leak client certificate to cross-origin redirect target `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1694 › should highlight locator in iframe while typing `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1914 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:523 › emulate media should not be affected by second connectOverCDP with noDefaults `@chrome-windows-latest`
⚠️ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:179 › should have passed URL when launching with ignoreDefaultArgs: true `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:129 › selector generator › should use consistent exactness for name and description `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:165 › selector generator › should try to improve text by shortening `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:185 › selector generator › should escape text with quote `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:503 › selector generator › should use the name attributes for elements that can have it `@chrome-macos-latest`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-library] › library/inspector/recorder-api.spec.ts:83 › should double click `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-15-large`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1996 › canvas clipping `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/page-goto.spec.ts:460 › should disable timeout when its set to 0
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

110615 passed, 4715 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — both real failures are pre-existing Chromium flakes

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

This PR only bumps the WebKit binary (browsers.json23552358). The two non-flaky failures are both Chrome/Chromium timeouts on macOS — code paths a WebKit roll can't touch — and both have timed out before on unrelated SHAs. Nothing here points back to this change.

Details

Overall: across the three reports, "tests 1" had only 4 flaky tests (all rescued on retry), "MCP" had one real failure, and "tests 2" had one real failure plus 23 flaky. Neither real failure is a WebKit test.

Pre-existing flake / infra

  • [chrome] › mcp/cli-parsing.spec.ts:67 › wrong argument type@mcp-macos-latest-chrome — pre-existing flake. Across the test-results DB this test failed 2 of 2218 chrome runs, both timedOut; the other occurrence was on PR fix(storageState): close IndexedDB connections opened by collect and restore #42260 (sha 5c903e14, 2026-08-14) — a run this WebKit roll can't be responsible for. It's a Chrome MCP CLI-argument-parsing test, unreachable by a browser-revision bump.

  • [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced)@chrome-macos-latest — pre-existing flake. This test failed 3 of 7899 chromium-library runs, all timedOut; two of those were on main pushes unrelated to any PR (sha 3e95c6c8, 2026-07-22 and sha bcb3563a, 2026-08-12). It's a Chromium service-worker networking test — nothing a WebKit roll exercises.

Flaky, not triaged (passed on retry, none WebKit-specific): the 4 from "tests 1" (chromium.spec.ts:179 serviceWorker, video.spec.ts:294 screencast, beforeunload.spec.ts:130, ui-mode-test-update.spec.ts:202) and the 23 from "tests 2" — predominantly Chromium/Chrome service-worker, CDP, and selector-generator tests, plus a couple of Firefox and Android ones. The lone WebKit flake (trace-viewer.spec.ts:1996 › canvas clipping@webkit-macos-15-xlarge) passed on retry and isn't a triage signal on its own.

If a WebKit test had failed for real, that'd be the interesting result — but none did. The roll looks clean from a CI standpoint.

Triaged by the Playwright bot - agent run

@dcrousso
Devin Rousso (dcrousso) merged commit 437ddf4 into mainAug 28, 2026
73 of 75 checks passed
@dcrousso
Devin Rousso (dcrousso) deleted the roll-into-pw-webkit/2358 branch August 28, 2026 16:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dcrousso