replace pxt_powi implementation with better one - #1484
Merged
Conversation
Joey Wunderlich (jwunderl)
approved these changes
Aug 26, 2024
Sarah Rietkerk (srietkerk)
approved these changes
Aug 26, 2024
curlyz
pushed a commit
to curlyz/pxt-common-packages
that referenced
this pull request
Feb 20, 2025
* replace pxt_powi implementation with better one * add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#2192
We've long had an optional define (
PXT_POWI) which can be used to prevent the compile from pulling in the std implementation ofpow(which is 4k of code by itself). As far as I know, this flag is only actually used in the pxt-microbit to prevent hex size issues with the v1 micro:bit.The historic PXT_POWI implementation casts the exponent to an integer which obviously provides pretty inaccurate results. This new implementation instead takes advantage of the fact that for positive non-zero x values:
expandlogare already pulled into the hex, so this doesn't increase the hex file size at all (i verified this locally)this is mostly based on Martin Williams (@martinwork)'s implementation with some extra handling when x=0