Uh oh!
There was an error while loading. Please reload this page.
Upgrade to Blocky 12.2.0-beta.0 and new keyboard nav plugin - #10707
Merged
Richard Knoll (riknoll) merged 20 commits intoJun 27, 2025
Merged
Conversation
Re-focus previously focused block in the flyout if possible.
The workaround equivalent shipped in 12.1.0.
The format was aligned with the others in the plugin.
These buttons are removed from the DOM and re-rendered when interacted with. As a result focus is lost. This change re-focuses the block when this happens.
This includes the expand / collapse buttons for functions.
Hard to tell if the opacity is intended, it's quite odd really but would be a meaningful visual change.
Aligns with RaspberryPiFoundation/blockly#9153 Workspace comments need a separate fix from Blockly.
ContributorAuthor
This is a draft because I've not tested it since updating to the Blockly releases. I'll pick up in my morning, but any feedback if you get a chance to look today would be great. Blockly releases are beta for the moment to give Blockly time before final releases but they essentially only contain the changes we're waiting for and have been tracking so I think risk in using them is low. |
Matt Hillsdon (microbit-matt-hillsdon)
marked this pull request as ready for review
June 27, 2025 12:36
ContributorAuthor
Happy with this now. |
Richard Knoll (riknoll)
requested changes
Jun 27, 2025
| }); | ||
| // Don't let the pointerdown event get to the workspace. | ||
| browserEvents.conditionalBind(textArea, 'pointerdown', this, (e: Event) => { | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
need to call clearTouchIdentifier here
Matt Hillsdon (microbit-matt-hillsdon)
requested a review
from Richard Knoll (riknoll)June 27, 2025 20:57
Richard Knoll (riknoll)
approved these changes
Jun 27, 2025
Richard Knoll (riknoll)
enabled auto-merge (squash)
June 27, 2025 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a deployment https://blocky-12-2-0-beta.review-pxt.pages.dev/
As the commits below have tracked Blockly as it's evolved it probably makes sense to squash them away when we're ready to merge.