Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 20, 2025. It is now read-only.
Rework dependencies order for hash generation - #2204
Merged
Aleksandr Nekrashevich (alexnekrashevich) merged 2 commits intoJan 12, 2022
Merged
Conversation
Lukas Cenovsky (lucen-ms)
approved these changes
Jan 12, 2022
Tomas Vahalik (vahalik)
approved these changes
Jan 12, 2022
Ondřej Merkun (ondrej-merkun-ms)
approved these changes
Jan 12, 2022
Aleksandr Nekrashevich (alexnekrashevich)
deleted the
v-aleksandrn/rework-gradle-hash-order
branch
January 12, 2022 20:57
Sourabh Debnath (sourabhdebnath) pushed a commit
to scripbox/react-native-code-push
that referenced
this pull request
May 2, 2022
* Rework dependencies order for hash generation * Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#838#1981
The reason why CodePushHash might not be in final APK in some cases is the wrong order of Gradle tasks (assets are copied before the hash generation).
This PR shall resolve this.