Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 20, 2025. It is now read-only.
Smarter node modules path resolving - #2558
Merged
Merged
Conversation
Jay Kim (wjaykim)
commented
Jul 28, 2023
ContributorAuthor
@microsoft-github-policy-service agree |
MikhailSuendukov
previously approved these changes
Jul 3, 2024
Contributor
Hello Jay Kim (@wjaykim) thank you for your contribution, are these changes still relevant for you also did you mange to test them in some complex rn projects? |
Jay Kim (wjaykim)
commented
Jul 4, 2024
ContributorAuthor
Djordje (@DordeDimitrijev) Yes, I’m currently using the patched code to use codepush in my rn project in monorepo. |
Dmitriy Kirakosyan (DmitriyKirakosyan)
approved these changes
Jul 5, 2024
Evgenii Dergachev (DergachevE)
approved these changes
Jul 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added findNodeModulePath script to codepush.gradle, which add supports for complex rn projects such as monorepo.