Uh oh!
There was an error while loading. Please reload this page.
Fix NPE when invoking copyNecessaryFilesFromCurrentPackage() method on Android - #2566
Conversation
Hi Rob X (@robxyy) , thank you for the contribution! Let me leave a couple of comments on your change. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Djordje (DordeDimitrijev)
commented
Jul 29, 2024
Hi Rob X (@robxyy) these changes were reverted from release 8.3.0 of rn-codepush and latest 8.3.1 hotfix doesn't include them. Reason behind this is that customers reported rollbacks of update and I traced it back to these changes. If you wish to keep these changes and resolve this issue take a look #2725 |
Rob X (robxyy)
commented
Jul 29, 2024
Sorry to hear that. I missed |
Fix#2087. It looks like NPE is caused by CodePushUpdateManager.java#L79. When invoking
copyNecessaryFilesFromCurrentPackage()method, IfcurrentPackageFolderPathisnull, copyingcurrentPackageFolderPathtonewUpdateFolderPathwill be discarded.