Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Bump the version of ZipArchive to 2.5.5 - #2709

Merged
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 4 commits into
masterfrom
ziparchive-bump
Sep 9, 2024
Merged

Bump the version of ZipArchive to 2.5.5#2709
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 4 commits into
masterfrom
ziparchive-bump

Conversation

@MikhailSuendukov

@MikhailSuendukovMikhailSuendukov commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

This PR upgrades ZipArchive to version 2.5.5 with the following fixes:

Related items

#2679
#2748
AB#104743

@MikhailSuendukov
MikhailSuendukov requested a review from a team as a code ownerJune 12, 2024 16:21
@MikhailSuendukovMikhailSuendukov changed the title Bump the version of zipArchive to 2.5.5Bump the version of ZipArchive to 2.5.5Jun 12, 2024
@DmitriyKirakosyan

Dmitriy Kirakosyan (DmitriyKirakosyan) commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

This PR introduces a breaking change, requiring bumping min ios version to 15. As we are not planning to bump minimum ios version to 15, let's close it for now.

We are going to bump min iOS and tvOS versions to 15.5 according to the SSZipArchive library requirements.
We can do it as iOS 14 is out of support. See https://endoflife.date/ios

@DmitriyKirakosyan

Copy link
Copy Markdown
Contributor

MikhailSuendukov I've applied required changes to the Xcode project and adjusted min iOS version. I tested this PR on a fresh react-native@0.73 project. It works.
However, there is something we should adjust in iOS project, i.e. overriding min ios version by replacing the line:

platform :ios, min_ios_version_supported

with:

platform :ios, '15.5'

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MikhailSuendukov@DmitriyKirakosyan@JiglioNero@lucen-ms