Skip to content

[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030

Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom
Saadnajmi:66-backports
Feb 19, 2022
Merged

[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom
Saadnajmi:66-backports

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Feb 19, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:

#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+
And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread

I had to manually recreate 1012 because it wasn't squashed when merged.

@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a teamFebruary 19, 2022 00:01
@pull-bot

Pull Request Analyser (pull-bot) commented Feb 19, 2022

Copy link
Copy Markdown
Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193

@Saadnajmi
Saad Najmi (Saadnajmi) merged commit 7b6aa55 into microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the 66-backports branch February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[0.66] Backport a few of 10.15+ changes to 0.66 stable by Saadnajmi · Pull Request #1030 · microsoft/react-native-macos · GitHub
Skip to content
[0.66] Backport a few of 10.15+ changes to 0.66 stable - #1030
Merged
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Feb 19, 2022
Merged
[0.66] Backport a few of 10.15+ changes to 0.66 stable#1030
Saad Najmi (Saadnajmi) merged 5 commits into
microsoft:0.66-stablefrom 
Saadnajmi:66-backports
Conversation
@Saadnajmi
@SaadnajmiSaad Najmi (Saadnajmi)
commented
Feb 19, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
This is a cherry-pick of 5 changes from main to 0.66-stable, mostly related to bumping our min OS to 10.15:
#938 - Remove some pre 10.15 Availability checks
#924 - Use NSSwitch
#1028 - Fix some main thread checker violations in DynamicColorMacOS
#1029 - Replace currentAppearance with currentDrawingAppearance on macOS 11+

And I manually added:
#1012 - Only call +[NSAppearance currentAppearance] on the main thread
I had to manually recreate 1012 because it wasn't squashed when merged.
@Saadnajmi@pull
@ryanlntn@ntre@mganandrajMuhammad Hamza Zaman
RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)
5c482e9
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* [pull] master from microsoft:master (#11)
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Use NSSwitch
* remove change from my fork
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
DynamicColorMacOS fixes (microsoft#1028)
6beda37
* Use initWithDynamicProvider + Add HC Support
* Update log error
@Saadnajmi
replace all references to 10.14 (microsoft#938)
59839fa
@Saadnajmi
Replace currentAppearance with currentDrawingAppearance on macOS 11+ (m…
cc3880c
…icrosoft#1029)
@Saadnajmi
Manually cherry-pickmicrosoft#1012
8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
requested a review
from a teamFebruary 19, 2022 00:01
@pull-bot
Pull Request Analyser (pull-bot)
commented
Feb 19, 2022

Copy link


Copy Markdown

Warnings
⚠️
❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
DetailsCATEGORY may be:

  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f03193
@Saadnajmi
Saad Najmi (Saadnajmi)
merged commit 7b6aa55
into
microsoft:0.66-stableFeb 19, 2022
@Saadnajmi
Saad Najmi (Saadnajmi)
deleted the

66-backports

branch
February 19, 2022 02:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@amgleitmanAdam Gleitman (amgleitman)amgleitman approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@amgleitman