Skip to content

remove references to RCTDynamicColor - #1060

Merged
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:dynamic-color-fallout
Mar 2, 2022
Merged

remove references to RCTDynamicColor#1060
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:dynamic-color-fallout

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

In #1028 I removed RCTDynamicColor.h/.m . There was still an explicit reference to the class in our unit tests. I'm not sure why that wasn't caught.

Changelog

[macOS] [Fixed] - Removed reference to RCTDynamicColor in our unit tests.

Test Plan

CI should pass.

@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a team as a code ownerMarch 2, 2022 19:57
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit ff4f71d into microsoft:mainMar 2, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the dynamic-color-fallout branch March 2, 2022 22:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Saadnajmi@HeyImChris