Merge pull request #1236 from rasaha91/cherry-pick-appcompat-upgrade by rasaha91 · Pull Request #1237 · microsoft/react-native-macos

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

rasaha91 · 2022-07-07T20:08:47Z

Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to react#33065)

Closesreact#31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Pull Request resolved: react#33072

Test Plan: Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

Reviewed By: cortinico

Differential Revision: D34107105

Pulled By: ShikaSD

fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

Pull Request Analyser (pull-bot) · 2022-07-07T20:13:28Z

	Fails
🚫	`node` failed.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 07 Jul 2022 20:13:18 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D222:2276:10DDFC7:313CB0C:62C73E5E',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1657228396',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1237/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c52df55

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Merge pull requestmicrosoft#1236from rasaha91/cherry-pick-appcompat…
c52df55
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1

rasaha91 requested a review from a team as a code owner July 7, 2022 20:08

rasaha91 enabled auto-merge July 7, 2022 20:10

Saad Najmi (Saadnajmi) approved these changes Jul 7, 2022
View reviewed changes

Anandraj (mganandraj) approved these changes Jul 7, 2022
View reviewed changes

rasaha91 merged commit 4a12e63 into microsoft:0.68-stableJul 7, 2022

Uh oh!

Conversation

rasaha91 commented Jul 7, 2022

Changelog

Uh oh!

Pull Request Analyser (pull-bot) commented Jul 7, 2022

Log

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rasaha91 commented Jul 7, 2022

Changelog

Uh oh!

Pull Request Analyser (pull-bot) commented Jul 7, 2022

Log

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rasaha91 commented Jul 7, 2022

Changelog

Uh oh!

Pull Request Analyser (pull-bot) commented Jul 7, 2022

Log

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rasaha91 commented Jul 7, 2022

Changelog

Uh oh!

Pull Request Analyser (pull-bot) commented Jul 7, 2022

Log

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rasaha91 commented Jul 7, 2022

Changelog

Uh oh!

Pull Request Analyser (pull-bot) commented Jul 7, 2022

Log

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants