Fix Flow and ESLint errors. - #14

Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom
tom-un:tomun/flow-lint
Mar 14, 2019
Merged

Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom
tom-un:tomun/flow-lint

Conversation

@tom-un

@tom-unTom Underhill (tom-un) commented Mar 13, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  • I am making a change required for Microsoft usage of react-native
  • I am making a fix / change for the macOS implementation of react-native

Description of changes

ESLint

There were a large number of ESLint errors due to changes made for macos and windows.
Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix
the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.

Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.
DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.

in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef

Flow

A few Flow issues have crept in since I made a previous change fixing all the flow errors.

ActivityIndicatory.js
color type was change from string to `string | SemanticOrDynamicColorType

TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes

ReactNativeViewAttributes.js
tabIndex:true needed to be added

ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added

There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.

/azp run

@tom-un

Tom Underhill (tom-un) commented Mar 14, 2019

Copy link
Copy Markdown
CollaboratorAuthor

/azp run

@azure-pipelines

azure-pipelinesBot commented Mar 14, 2019

Copy link
Copy Markdown

No pipelines are associated with this pull request.

HeyImChris
HeyImChris approved these changes Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*

@HeyImChrisHeyImChrisMar 14, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.

Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms) merged commit 0d619f8 into microsoft:masterMar 14, 2019
t-nanava pushed a commit that referenced this pull request Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un) deleted the tomun/flow-lint branch May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit to NickGerleman/react-native that referenced this pull request May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms
1 more reviewer
@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)

@tom-unTom Underhill (tom-un)

@HeyImChrisHeyImChris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix Flow and ESLint errors. - #14
Merged
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Mar 14, 2019
Merged
Fix Flow and ESLint errors.#14
Andrew Coates (acoates-ms) merged 2 commits into
microsoft:masterfrom 
tom-un:tomun/flow-lint
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Mar 13, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Please select one of the following
  •  I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
  •  I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
  •  I am making a change required for Microsoft usage of react-native
  •  I am making a fix / change for the macOS implementation of react-native
Description of changes
ESLint
There were a large number of ESLint errors due to changes made for macos and windows.

Most of the changes were made the tool itself via:
npm run lint -- --quiet --fix

the --quiet switch means to silence warning and therefore report and fix only errors, not warnings.
Most of the fixed errors were merely style changes, but three code errors were found and fixed manually:
accessiblityHint was added by Microsoft and then later by Facebook. Most of it was already merged, but in ViewPropTypes the PropType was being exported twice.

DatePickerMacOS.android.js defined dummyDatePickerMacOS instead of DummyDatePickerMacOS.
in scripts/autoSync.js eslint was complaining about Buffer not being required even though it is a global thing in node.js. Just added // eslint-disable-line no-undef
Flow
A few Flow issues have crept in since I made a previous change fixing all the flow errors.
ActivityIndicatory.js

color type was change from string to `string | SemanticOrDynamicColorType
TouchableWithoutFeedback.js:
tabIndex: PropTypes.number and tooltip: PropTypes.string needed to be added to the PropTypes
ReactNativeViewAttributes.js
tabIndex:true needed to be added
ViewPropTypes.js
tabIndex?: number and tabIndex: PropTypes.number added
There are a handful of errors in node_modules file not directly in our control. I just exclude them via the .flowconfig file. The rn-cli.config.js has some SDX platform things added that don't work when not a subtree of sdx-platform so I also excluded that file.
/azp run
@tom-un
Tom Underhill (tom-un)
commented
Mar 14, 2019

Copy link


Copy Markdown

CollaboratorAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Mar 14, 2019

Copy link


Copy Markdown

No pipelines are associated with this pull request.
HeyImChris
HeyImChris
approved these changes
Mar 14, 2019
View reviewed changes
Comment thread.flowconfig

; Ignore metro
; .*/node_modules/metro/.*
.*/node_modules/metro/.*
@HeyImChrisHeyImChrisMar 14, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close does this get us to the CI loops passing? If we're still not close, there's always the risk these just break again without people realizing.
Comment thread.flowconfig
@acoates-ms
Andrew Coates (acoates-ms)
merged commit 0d619f8
into
microsoft:masterMar 14, 2019
t-nanava pushed a commit
that referenced
this pull request
Jun 17, 2019
@tom-un@acoates-ms
Fix Flow and ESLint errors. (#14)
c78d246
* Fix Flow and ESLint errors.
* Fixed some warnings in code that is in the MS fork only.
@tom-un
Tom Underhill (tom-un)
deleted the

tomun/flow-lint

branch
May 8, 2020 21:47
Nick Gerleman (NickGerleman) pushed a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2025
@sammy-SC@facebook-github-bot
fix crash in view culling where differentiator creates create instruc…
34e9cba
…tion for existing view (react#51294)
Summary:
Pull Request resolved: react#51294
changelog: [internal]
Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated.
The differentiator would generate a create instruction for a view that already exists.
Stack trace for the crash:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8
frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264
frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100
frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128
frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296
frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124
frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468
frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12
frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32
frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88
frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384
frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268
frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528
frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356
frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80
frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40
frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44
frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10
frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3
frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544
frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456
frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308
frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40
frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24
frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12
frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24
frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184
frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40
frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920
frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536
frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164
frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796
frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124
frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200
frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20
frame microsoft#39: 0x0000000111506b4c dyld`start + 6000
```
Reviewed By: rubennorte
Differential Revision: D74654157
fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@acoates-msAndrew Coates (acoates-ms)Awaiting requested review from acoates-ms

1 more reviewer

@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@markavitaleMark A Vitale (markavitale)
@tom-unTom Underhill (tom-un)
@HeyImChrisHeyImChris

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tom-un@acoates-ms@HeyImChris@markavitale