[0.68] Refactor how focusable is handled in RCTView

[Saad Najmi (Saadnajmi)]

Copy of #1437 into 0.68-stable

[Pull Request Analyser (pull-bot)]

	Fails
🚫	node failed.
🚫	❔ This pull request needs a description.

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message. Details CATEGORY may be: General macOS iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Log

Error: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1456/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Wed, 26 Oct 2022 17:02:26 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'DDDE:73EB:2C4EB44:5ADBF69:63596822',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4976',
'x-ratelimit-reset': '1666804974',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '24',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1456/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against f30a7ac

[Lynn Zhang (lyzhan7)]

This PR looks slightly different from the original one, do you need the [self.layer setPDisplay] line for 0.68?

[Saad Najmi (Saadnajmi)]

self.layer setPDisplay

Where do you see that line? Might be a difference between our main branch and our [0.68-stable] branch. The former generally has more commits.

[Lynn Zhang (lyzhan7)]

self.layer setPDisplay

Where do you see that line? Might be a difference between our main branch and our [0.68-stable] branch. The former generally has more commits.

First change here

[Saad Najmi (Saadnajmi)]

self.layer setPDisplay

Where do you see that line? Might be a difference between our main branch and our [0.68-stable] branch. The former generally has more commits.

First change here

Oh no... setPDisplay was a typo that shouldn't have made it in 😅

Gonna go fix that now....
EDIT: OK phew my other PR (rightfully) didn't merge, so we're good :D