Skip to content

[Fabric] Convert UIView to RCTUIView shim - #1524

Merged
Saad Najmi (Saadnajmi) merged 10 commits into
microsoft:mainfrom
shwanton:fabric/rctuiview-shim
Dec 7, 2022
Merged

[Fabric] Convert UIView to RCTUIView shim#1524
Saad Najmi (Saadnajmi) merged 10 commits into
microsoft:mainfrom
shwanton:fabric/rctuiview-shim

Conversation

@shwanton

@shwantonShawn Dempsey (shwanton) commented Nov 28, 2022•
edited
Loading

Copy link
Copy Markdown

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:
Replacing references of UIView to RCTUIView shim

Changelog

[macOS][Fabric] - Replacing references of UIView to RCTUIView shim

Test Plan

[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no UIView errors
CleanShot 2022-11-23 at 13 04 18

Build RNTester-macOS_2022-11-23T13-02-55.txt

[x] Build RNTester - iOS w/ Fabric - should work
https://user-images.githubusercontent.com/96719/203647093-7d05dff3-760a-4053-9d4b-164d133482aa.mp4

[x] Build RNTester-macOS w/ Paper - should work
https://user-images.githubusercontent.com/96719/203647140-a37bbc9e-53b1-4628-b1e7-7c4a14754c58.mp4

[x] Build RNTester - iOS w/ Paper - should work
https://user-images.githubusercontent.com/96719/203646958-e64d1c13-580f-446d-8b87-d452f7c38932.mp4

@shwantonShawn Dempsey (shwanton) mentioned this pull request Nov 28, 2022
Closed
4 tasks
shwanton
Shawn Dempsey (shwanton) commented Nov 28, 2022
View reviewed changes
Comment threadReact/Fabric/Surface/RCTFabricSurface.h
@shwanton
Shawn Dempsey (shwanton) marked this pull request as ready for review November 30, 2022 19:49
Saadnajmi
Saad Najmi (Saadnajmi) reviewed Nov 30, 2022
View reviewed changes
Comment threadReact/Views/RCTWrapperViewController.h
@SaadnajmiSaad Najmi (Saadnajmi) linked an issue Dec 1, 2022 that may be closed by this pull request
Replace UIView with RCTUIView #1536
Closed
Shawn Dempsey added 3 commits December 6, 2022 15:03
Saadnajmi
Saad Najmi (Saadnajmi) reviewed Dec 6, 2022
View reviewed changes
Comment threadReact/Fabric/Mounting/ComponentViews/ScrollView/RCTEnhancedScrollView.mm Outdated
Saadnajmi
Saad Najmi (Saadnajmi) reviewed Dec 6, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit 1ae2e06 into microsoft:mainDec 7, 2022
@shwanton
Shawn Dempsey (shwanton) deleted the fabric/rctuiview-shim branch December 7, 2022 19:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees

@SaadnajmiSaad Najmi (Saadnajmi)

Labels

Partner: Facebook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace UIView with RCTUIView

2 participants

@shwanton@Saadnajmi