Skip to content

[visionOS] Bring back missing ScrollView prop converters - #2091

Merged
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:scrollview
Mar 8, 2024
Merged

[visionOS] Bring back missing ScrollView prop converters#2091
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:scrollview

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

In #2019 , we ifdefed out some props that were actually valid on visionOS, namely UIScrollViewContentInsetAdjustmentBehavior and UIScrollViewIndicatorStyle. Let's bring them back by adjusting the ifdefs

Changelog:

[VISIONOS] [FIXED] - Bring back missing ScrollView prop converters

Test Plan:

CI should pass. visionOS should compile locally.

@Saadnajmi
Saad Najmi (Saadnajmi) enabled auto-merge (squash) March 8, 2024 08:29
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit b53a6d4 into microsoft:mainMar 8, 2024
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the scrollview branch March 8, 2024 17:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Saadnajmi@tido64