[0.73] Fix new role prop after JS-Shim was removed by Meta by FalseLobster · Pull Request #2100 · microsoft/react-native-macos

Alicia Drummond (FalseLobster) · 2024-03-20T23:55:21Z

Summary:

Prior to 0.73, the new role prop was remapped to accessibilityRole on the JS-side. Starting with react#37304, the work needs to be completed on the native side. Since the new prop is ARIA inspired, the mappings are taking from the ARIA Core AAM which disagrees with some of the mappings used in the old accessibilityRole prop. Users of the old prop are unaffected, but the new prop will take the mappings from the spec.

Test Plan:

Tested a variety of permutations of accessibilityRole and role to confirm the behavior looks correct in Accessibility Inspector

…ve-macos into allyrole73

Saad Najmi (Saadnajmi) · 2024-03-21T00:35:32Z

An aside, we'll want to eventually also implement for Fabric, but not blocking for 0.73

Saad Najmi (Saadnajmi) · 2024-03-21T20:14:09Z

Q: Would it make sense for our main branch version of the PR to use the aria mappings for the accessibilityRole slot, rather than the legacy mappings we defined? I I can imagine we keep the legacy mappings for one version (0.73) and disable it in the next (0.74). Alternatively, maybe put it behind a Feature flag via this JS file or this native file ?

Alicia Drummond (FalseLobster) · 2024-03-21T20:35:14Z

Q: Would it make sense for our main branch version of the PR to use the aria mappings for the accessibilityRole slot, rather than the legacy mappings we defined? I I can imagine we keep the legacy mappings for one version (0.73) and disable it in the next (0.74). Alternatively, maybe put it behind a Feature flag via this JS file or this native file ?

Maybe, I'm open to it. I kinda suspect at some point Meta will drop accessibilityRole like they did accessibilityTraits (even though our impl still has accessibilityTraits). I think we run the risk internally of breaking partners who are using accessibilityRole if we silently change some mappings for them, whereas only applying the new mappings to the new values to the new prop feels safe, which is worth considering, but I suppose that's why you're calling out the feature flag :)

## Summary: main targeted PR of #2100 Prior to 0.73, the new `role` prop was remapped to `accessibilityRole` on the JS-side. Starting with react#37304, the work needs to be completed on the native side. Since the new prop is ARIA inspired, the mappings are taking from the [ARIA Core AAM](https://www.w3.org/TR/core-aam-1.2/#mapping_role_table) which disagrees with some of the mappings used in the old `accessibilityRole` prop. Users of the old prop are unaffected, but the new prop will take the mappings from the spec. ## Test Plan: Tested a variety of permutations of accessibilityRole and role to confirm the behavior looks correct in Accessibility Inspector

Alicia Drummond (FalseLobster) added 6 commits March 5, 2024 12:48

update podfile.lock
78e1c23

fix role prop
286347c

fix some issues
ea9c697

Merge branch '0.73-stable' ofhttps://github.com/microsoft/react-nati…
496f070
…ve-macos into allyrole73

Add a few more comments
84b0a16

Add fallback logic and array support for role
5b20839

Alicia Drummond (FalseLobster) requested a review from a team as a code owner March 20, 2024 23:55