Uh oh!
There was an error while loading. Please reload this page.
fix(fabric): Add conditional coordinate space conversion for native view hit testing - #2291
Merged
Saad Najmi (Saadnajmi) merged 3 commits intoNov 29, 2024
Merged
Conversation
…hit testing Summary: Native views use the AppKit api for hit testing which requires the point to be in the superview coordinate system. This diff updates the hit testing in `RCTViewComponentView` to conditionally converts the point to the target view coordinate system only if the tested view is a react view. Test Plan: Run Zeratul with Fabric and select text inside message bubbles. The scroll view being a native view, the hit testing does not require a point conversion. With this change, the text selection works as expected. | Before | After | |--| | https://pxl.cl/3Mlpb | https://pxl.cl/3MllN | Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D51129375 Tags: uikit-diff
Saad Najmi (Saadnajmi)
requested review from
Adam Gleitman (amgleitman) and Tommy Nguyen (tido64)November 21, 2024 21:56
Uh oh!
There was an error while loading. Please reload this page.
…st:withEvent:]` more transparent
Saad Najmi (Saadnajmi)force-pushed
the
fabric/coordinates
branch
from
November 28, 2024 23:55
43def8d to
953c929CompareTommy Nguyen (tido64)
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs where we are cherry-picking fixes from #2117 to update our Fabric implementation on macOS.
Summary:
Unlike UIKit, AppKit hit testing requires the point to be in the superview coordinate system. As such, we have to override hit testing in React Native macOS to match the assumed iOS semantics.
Followup change I made to the original commit: I removed the
RCTViewimport/check for hit testing inRCTViewComponentViewbecause I don't think we'll ever be moving paper and fabric views like that.Test Plan:
CI should pass, maybe also try picking 71fae19 and see if selection works now