Uh oh!
There was an error while loading. Please reload this page.
feat(fabric): Implement Drag and Drop on View - #2713
Merged
Conversation
Summary: Add support for `draggedTypes` to the View component, enabling the configuration of a native view as a drop target. Test Plan: * Run Zeratul with Fabric enabled * Drag a file over the messages view and check that the cursor is changing indicating a drop target https://pxl.cl/4ldkW Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Subscribers: taskcreeper Differential Revision: https://phabricator.intern.facebook.com/D53674739
Saad Najmi (Saadnajmi)force-pushed
the
drag-drop
branch
from
October 1, 2025 22:01
decc891 to
daad2f3CompareSaad Najmi (Saadnajmi)
marked this pull request as ready for review
October 1, 2025 22:19
added 2 commits
October 1, 2025 15:25
Summary: Add the drag and drop event emitters to View with the payload conversion matching the Paper API for dragEnter/dragLeave/drop events. Test Plan: Tested later in this stack. Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D53674738
Summary: Add support for drag and drop to the `ViewComponent` for files and images. The implementation converts the dropped pasteboard items the same way as in Paper. The `DataTransferItem` resulting from the pasteboard conversion of the dragged items is used to build the JS payload for the dragEnter/dragLeave/drop events. Test Plan: * Run Zeratul with Fabric enabled * Drag and drop an image on the messages view * Send the attachment https://pxl.cl/4ldB7 Reviewers: shawndempsey, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D53674742
Saad Najmi (Saadnajmi)force-pushed
the
drag-drop
branch
from
October 1, 2025 22:26
3261b1e to
f1c03bfCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Patrick Boyd (PPatBoyd)
commented
Oct 2, 2025
fascinating -- would love to see a video and also a link to relevant docs for the current (core or community) API being supported here! |
Saad Najmi (Saadnajmi)
commented
Oct 2, 2025
CollaboratorAuthor
I can link the PR where it was implemented for paper.. we have a demo in RNTester |
Saad Najmi (Saadnajmi)force-pushed
the
drag-drop
branch
from
October 3, 2025 00:32
47cfc2b to
3d8f5f8CompareSaad Najmi (Saadnajmi)
marked this pull request as draft
October 3, 2025 01:02
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Saad Najmi (Saadnajmi)force-pushed
the
drag-drop
branch
from
October 3, 2025 19:21
2d4bee4 to
9a6095cCompareSaad Najmi (Saadnajmi)
marked this pull request as ready for review
October 4, 2025 01:22
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Saad Najmi (Saadnajmi)force-pushed
the
drag-drop
branch
from
October 6, 2025 17:19
ddb1bc2 to
23c38b1CompareTommy Nguyen (tido64)
approved these changes
Oct 7, 2025
Saad Najmi (Saadnajmi)
enabled auto-merge (squash)
October 7, 2025 08:07
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Cherry pick more commits from #2117 to implement Drag and Drop Support on View.
Test Plan:
Moved the TextInput example (which doesn't work on Fabric yet) to a new page, and added a View example (which does work on Fabric)
Screen.Recording.2025-10-03.at.4.39.11.PM.mov