Uh oh!
There was an error while loading. Please reload this page.
feat(fabric): merge the rest of relevant changes from meta/pristine - #2728
Closed
Saad Najmi (Saadnajmi) wants to merge 5 commits into
Closed
feat(fabric): merge the rest of relevant changes from meta/pristine #2728Saad Najmi (Saadnajmi) wants to merge 5 commits into
Saad Najmi (Saadnajmi) wants to merge 5 commits into
Conversation
Saad Najmi (Saadnajmi)force-pushed
the
more-3
branch
3 times, most recently
from
October 14, 2025 15:50
cc75f9d to
93fa46cCompareSaad Najmi (Saadnajmi)force-pushed
the
more-3
branch
from
October 16, 2025 22:55
93fa46c to
ceec57dCompareSaad Najmi (Saadnajmi)
commented
Oct 16, 2025
CollaboratorAuthor
Closing as I'm not sure there's more we can take out of here easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #2727 to land first
Summary:
Merge the
meta/pristinebranch, which contains the rest of the Meta desktops teams changes. Care was done to undo a lot of JS changes, it seems they use slightly different JS that is more flow-oriented. I focused on the native side of the code.Test Plan:
Testing..