fix(macos): align TouchableBounce focusable + AccessibilityInfo guards with upstream 0.83

[Thiago Vinhas (tvinhas)]

Summary

Two small JS-layer cleanups surfaced by a three-way-merge audit of fork-patched Libraries/Components/** files after the 0.83 upstream merge. Both fixes address divergence between the fork's [macOS] patches and upstream's restructured
0.83 logic.

1. TouchableBounce.js — missing onPress guard in macOS focusable check

Upstream 0.83 changed the focusable prop on the inner <Animated.View> of TouchableBounce.render() from:

focusable={this.props.focusable!==false&&!this.props.disabled}
to:
focusable={
this.props.focusable!==false&&this.props.onPress!==undefined&&!this.props.disabled}Thefork's [macOS] block — which replaces the upstream <Animated.View> prop set with a macOS-specific set including acceptsFirstMouse, enableFocusRing, tooltip, mouse/drag handlers, etc. — kept the pre-0.83 focusable shape, missing the
newonPress!==undefinedguard.EffectonmacOS: aTouchableBouncewithoutanonPresspropisstillTab-focusable/VoiceOver-reachable,eventhoughithasnointeraction.Decorativewrapperswronglygrabkeyboardfocus.Fix: addthesameonPress!==undefinedguardtothemacOSfocusablecheck.2.AccessibilityInfo.js—alignmacOSnoopcarve-outswithupstream's 0.83 android-first guard structure
Upstream0.83restructuredtwomethods—isBoldTextEnabled(line100)andisReduceTransparencyEnabled(line335)—from:
if(Platform.OS==='ios'){/* iOS native call */}else{returnPromise.resolve(false);}
to:
if(Platform.OS==='android'){returnPromise.resolve(false);}else{/* iOS native call */}(android-firstguard).Thefork's [macOS] blocks preserved the OLD if (ios) shape, which on macOS happens to land in the else branch and currently produces correct (noop) behavior. But this is structurally fragile:
-AfutureAppleplatformreportinganon-'ios'/non-'macos'Platform.OSwouldsilentlyfallintothemacOSelsebranch(currentlyfinesinceit's a noop, but a foot-gun if someone changes the else body).
-Thefork's diff against upstream is larger than necessary — every future merge will have to wrestle with this shape mismatch.
Fix: alignwithupstream's android-first guard, adding macos explicitly to the noop branch as an || Platform.OS === 'macos' /* [macOS] */ inline clause. Single-line diff against upstream; easy for future merges.
Together,theseclosetheaudititemfor"Audit upstream breaking changes"ontheRoadto0.83trackingissue(#2901).Theauditcovered9fork-patchedJSfiles;7wereclean(ViewNativeComponent,ReactNativeStyleAttributes,ScrollView,ScrollViewStickyHeader,TextInput,ImageInjection,ImageTypes)and2hadtheissuesfixedhere.TestPlan-TouchableBouncefocusable: codereview—themacOSguardmirrorsupstream's exactly, in the same precedence inside the [macOS]/macOS] block.
-AccessibilityInfo.isBoldTextEnabled/isReduceTransparencyEnabledonmacOS: bothstillreturnPromise.resolve(false)(verifiedbyreadingthenewguard—Platform.OS==='macos'matchestheearly-return).-iOSunchanged: samenativecall,sameerrormessage,samePromiseshape.-Flowtypes: nosignaturechanges;type-checkisunaffected.Related- #2901—Roadto0.83trackingissue(closesthe"Audit upstream breaking changes"itemalongsidetheearlierauditcommentnotingP1-P4alreadyabsorbedbythemerge).-Auditalsoflaggedathirdcandidate(TextInput.js:90,92RCTSingelineTextInputNativeComponenttypo'd require path), but verification showed both the file AND the require are consistently misspelled the same way — quirky, not broken.
Outofscope.

[Thiago Vinhas (tvinhas)]

@microsoft-github-policy-service agree

[Saad Najmi (Saadnajmi)]

Superseded by #3009