Skip to content

[0.62] Provide information to metro to redirect to rn-macos when building macos - #596

Merged
Andrew Coates (acoates-ms) merged 5 commits into
microsoft:0.62-stablefrom
acoates-ms:metroconfig62
Sep 15, 2020
Merged

[0.62] Provide information to metro to redirect to rn-macos when building macos#596
Andrew Coates (acoates-ms) merged 5 commits into
microsoft:0.62-stablefrom
acoates-ms:metroconfig62

Conversation

@acoates-ms

@acoates-msAndrew Coates (acoates-ms) commented Sep 14, 2020•
edited by ghost
Loading

Copy link
Copy Markdown

Port #587 to 0.62

Microsoft Reviewers: Open in CodeFlow

@acoates-msAndrew Coates
Provide information to metro to redirect to rn-macos when building ma…
462cceb
…cos (react#587)
* Provide information to metro to redirect to rn-macos when building macos
* Update version of cli we are using
* more config
Co-authored-by: Andrew Coates <acoates-ms@noreply.github.com>
@pull-bot

Pull Request Analyser (pull-bot) commented Sep 14, 2020•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 7bbe4f7

@acoates-ms

Andrew Coates (acoates-ms) commented Sep 14, 2020

Copy link
Copy Markdown
Author

/azp run

@azure-pipelines

azure-pipelinesBot commented Sep 14, 2020

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ghost

Deleted user (ghost) commented Sep 14, 2020

Copy link
Copy Markdown

Hello Andrew Coates (@acoates-ms)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@acoates-ms
Andrew Coates (acoates-ms) merged commit f59ede3 into microsoft:0.62-stableSep 15, 2020
alloy
Eloy Durán (alloy) reviewed Sep 16, 2020
View reviewed changes
Comment thread.ado/android-pr.yml
include:
- master
- 0.59-stable
- 0.62-stable

@alloyEloy Durán (alloy)Sep 16, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t these (going forward in master) be *-stable?

alloy
Eloy Durán (alloy) reviewed Sep 16, 2020
View reviewed changes
Comment thread.ado/templates/react-native-macos-init.yml
displayName: Bump package version
inputs:
script: node scripts/bump-oss-version.js --nightly
script: node scripts/bump-oss-version.js --ci 0.62.1000

@alloyEloy Durán (alloy)Sep 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we now have to update this every time we create a new stable branch or could this be inferred by the script from the current branch name?

@alloyEloy Durán (alloy)Sep 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bump the stable version of the react-native-macos package we use a different script. Would it be possible to use that here too and not introduce forked changes to the bump-oss-version.js script?

@tom-unTom Underhill (tom-un) mentioned this pull request Sep 21, 2020
Merged
4 tasks
@acoates-ms
Andrew Coates (acoates-ms) deleted the metroconfig62 branch September 2, 2022 17:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-unTom Underhill (tom-un)Awaiting requested review from tom-untom-un is a code owner
1 more reviewer
@alloyEloy Durán (alloy)alloy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acoates-ms@pull-bot@alloy