Skip to content

[0.63] Avoid eating clicks/taps into ScrollView when using physical keyboard… - #668

Merged
Eloy Durán (alloy) merged 3 commits into
microsoft:0.63-stablefrom
NickGerleman:scrollresppnder-63
Dec 8, 2020
Merged

[0.63] Avoid eating clicks/taps into ScrollView when using physical keyboard…#668
Eloy Durán (alloy) merged 3 commits into
microsoft:0.63-stablefrom
NickGerleman:scrollresppnder-63

Conversation

@NickGerleman

@NickGerlemanNick Gerleman (NickGerleman) commented Dec 7, 2020•
edited by ghost
Loading

Copy link
Copy Markdown

… (react#30374)

Summary:
This is an extension of react#29798 which was reverted due to cases where the soft keyboard could not be dismissed.

Changelog

[General] [Fixed] - Avoid eating clicks/taps into ScrollView when using physical keyboard

Pull Request resolved: react#30374

Test Plan: Validated with iOS simulator that taps on default ScrollView will dismiss soft keyboard and be eaten if open, but taps are not eaten when emulating a connected physical keyboard.

Reviewed By: kacieb

Differential Revision: D24935077

Pulled By: lyahdav

fbshipit-source-id: 19d9cf64547e40a35f9363896e3abbdccb95b546

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native
Microsoft Reviewers: Open in CodeFlow

@NickGerleman
Avoid eating clicks/taps into ScrollView when using physical keyboard (…
779825f
…react#30374)
Summary:
This is an extension of react#29798 which was reverted due to cases where the soft keyboard could not be dismissed.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[General] [Fixed] - Avoid eating clicks/taps into ScrollView when using physical keyboard
Pull Request resolved: react#30374
Test Plan: Validated with iOS simulator that taps on default ScrollView will dismiss soft keyboard and be eaten if open, but taps are not eaten when emulating a connected physical keyboard.
Reviewed By: kacieb
Differential Revision: D24935077
Pulled By: lyahdav
fbshipit-source-id: 19d9cf64547e40a35f9363896e3abbdccb95b546
@NickGerleman

Nick Gerleman (NickGerleman) commented Dec 7, 2020

Copy link
Copy Markdown
Author

Not bothering to cherry-pick into master since this will be cherry-picked into 0.64 upstream.

@pull-bot

Pull Request Analyser (pull-bot) commented Dec 7, 2020•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 87f3bfc

appden
Scott Kyle (appden) approved these changes Dec 7, 2020
View reviewed changes

@appdenScott Kyle (appden) left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so muchNick Gerleman (@NickGerleman)!

alloy
Eloy Durán (alloy) approved these changes Dec 8, 2020
View reviewed changes

@alloyEloy Durán (alloy) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NickGerleman

Nick Gerleman (NickGerleman) commented Dec 8, 2020

Copy link
Copy Markdown
Author

/azp run

@azure-pipelines

azure-pipelinesBot commented Dec 8, 2020

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@alloy

Eloy Durán (alloy) commented Dec 8, 2020

Copy link
Copy Markdown
Member

Looking into CI issues

@NickGerleman

Nick Gerleman (NickGerleman) commented Dec 8, 2020

Copy link
Copy Markdown
Author

Eloy Durán (@alloy) 🤔

@alloy

Eloy Durán (alloy) commented Dec 8, 2020

Copy link
Copy Markdown
Member

Hmm, unsure about that exclusion comment. When triggering it manually I ran into issues with Homebrew, which I was able to fix here, but I’m still somewhat naive about ADO. I guess it makes sense that the faulty installation is baked into the image and the fix needs to be ran for each run.

@alloy

Eloy Durán (alloy) commented Dec 8, 2020

Copy link
Copy Markdown
Member

I don’t know why this isn’t updated, but the build I triggered is now green https://dev.azure.com/ms/react-native/_build/results?buildId=126849&view=results 👍

@alloy
Eloy Durán (alloy) merged commit 408d308 into microsoft:0.63-stableDec 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@alloyEloy Durán (alloy)alloy approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NickGerleman@pull-bot@alloy@appden