Add some robustness to the CI and switch to Xcode 12 by HeyImChris · Pull Request #709 · microsoft/react-native-macos

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChris · 2021-02-04T21:24:09Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

We need to switch to Xcode 12 so let's leverage that fact we're in here to parameterize there versions so Xcode select is compatible with any future Xcode version changes we need to make going forward.

Changelog

[macOS/iOS] [Improvement] - Add robustness to CI

Test Plan

Will verify if the CI passes or not as this doesn't affect the product.

Microsoft Reviewers: Open in CodeFlow

Merge upstream into fork

Anand Rajeswaran (anandrajeswaran) · 2021-02-05T04:33:54Z

 - template: templates/apple-job-javascript.yml
 parameters:
 apply_office_patches: $(apply_office_patches)
+ slice_name: 'Xcode_12_2'


You should skip to 12.4

…acos

…macos into xcode12

Harrie Shin (harrieshin) · 2021-03-10T20:05:56Z

 s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
 s.license = package["license"]
 s.author = "Facebook, Inc. and its affiliates"
- s.platforms = { :ios => "10.0", :tvos => "10.0", :osx => "10.13" } # TODO(macOS GH#214)


ios=>"13.0" it will make our sizes small too...

I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)

HeyImChris · 2021-03-11T17:54:32Z

/azp run

azure-pipelines · 2021-03-11T17:54:58Z

Azure Pipelines successfully started running 2 pipeline(s).

Anand Rajeswaran (anandrajeswaran) · 2021-03-12T07:40:01Z

 signingOption: auto
 packageApp: false
 teamId: '$(XCodeSigningMicrosoftTeamID)'
- args: '-destination "${{ parameters.xcode_destination }}" ONLY_ACTIVE_ARCH=NO -verbose -UseModernBuildSystem=NO -derivedDataPath DerivedData ${{ parameters.xcode_extraArgs }}'


HeyImChris was there any particular reason you know of we were forcing legacy build system? I probably should have done things one at a time to control variables but this was a delta between CI and building locally in Xcode by default so seemed helpful to get rid of that to make it easier to reproduce CI issues?

The legacy build system used to be required before we built using cocoapods. The old static xcodeproj's from upstream had intentional circular dependencies that were worked around by having build order in the xcschemes. The new pod based builds don't have this issue anymore.

HeyImChrisand others added 12 commits May 14, 2020 15:03

Update RCTCxxBridge.mm
8df39e1

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
4a9bcbd

Merge pull request#1from microsoft/master
e8d2d8b
Merge upstream into fork

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
ab71c3b

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
e40c784

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
204ddb3

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
a76bcc1

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
7d85560

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
7011dc4

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
abfbabf

Merge branch 'master' ofhttps://github.com/microsoft/react-native-macos
19aa189

make CI xcode versioning more robust to xcode12
8206128

HeyImChris requested review from Andrew Coates (acoates-ms) and Harrie Shin (harrieshin)February 4, 2021 21:24

HeyImChris self-assigned this Feb 4, 2021

HeyImChris requested a review from Eloy Durán (alloy) as a code owner February 4, 2021 21:24

HeyImChris commented Feb 4, 2021
View reviewed changes

Comment thread.ado/apple-pr.yml Outdated

Harrie Shin (harrieshin) approved these changes Feb 4, 2021
View reviewed changes

Andrew Coates (acoates-ms) reviewed Feb 4, 2021
View reviewed changes

Comment thread.ado/apple-pr.yml Outdated

Anand Rajeswaran (anandrajeswaran) approved these changes Feb 5, 2021
View reviewed changes

update to xcode 12.4
23be475

Anand Rajeswaran (anandrajeswaran) approved these changes Feb 5, 2021
View reviewed changes

HeyImChris added 5 commits February 4, 2021 23:06

use apple variables file
3b2c1c7

Update RCTCxxBridge.mm
ea4f432

Merge branch 'master' ofhttps://github.com/HeyImChris/react-native-m…
41fd8d4
…acos

add quotes
bc002f5

switch to catalina
f01c601

Harrie Shin (harrieshin) approved these changes Feb 10, 2021
View reviewed changes

HeyImChris added 2 commits February 9, 2021 23:26

update pods to 10.15
5df978e

Merge branch 'master' ofhttps://github.com/HeyImChris/react-native-m…
645ccf0
…acos

HeyImChris added 10 commits March 9, 2021 15:26

make CI xcode versioning more robust to xcode12
29d1286

update to xcode 12.4
1f75063

use apple variables file
2970187

add quotes
3ad4df6

update to macOS 10.15
ac37210

update to xcode 12.4
d8f7530

use apple variables file
22e74c4

switch to catalina
06f74ba

10.14
ff9c754

Merge branch 'xcode12' ofhttps://github.com/HeyImChris/react-native-…
a583264
…macos into xcode12

ghost removed the Needs: Author Feedback label Mar 9, 2021

CI has to run on 10.15.4 or later
7d43df0

Anand Rajeswaran (anandrajeswaran) approved these changes Mar 10, 2021
View reviewed changes

HeyImChris added 2 commits March 10, 2021 10:16

fix up pod errors
72c2659

upgrade iphone simulator
2fa4dd9

Harrie Shin (harrieshin) reviewed Mar 10, 2021
View reviewed changes

HeyImChris added 3 commits March 10, 2021 14:00

iphone 13
ae75fb6

remove old post install script
99fa848

iphone 8
faa49d4

Anand Rajeswaran (anandrajeswaran) added 4 commits March 11, 2021 17:38

Restore Podfile.lock to see if it fixes CI
67e663b

Restore compiler flags in TurboModuleCxx-WinRTPort
4d5c7b8

Remove macOS arm64 build divergence
9d9d8fa

Remove building all ARCHS temporarily
17e61c9

Anand Rajeswaran (anandrajeswaran) reviewed Mar 12, 2021
View reviewed changes

Anand Rajeswaran (anandrajeswaran) added 2 commits March 12, 2021 12:08

Override ONLY_ACTIVE_ARCH in release builds too
c3b686f

Push iOS 14 snapshots
caac984

HeyImChris merged commit 3056c4e into microsoft:masterMar 17, 2021