Skip to content

[0.64] Fix publish builds by removing workspace from package.json before publish - #866

Merged
Andrew Coates (acoates-ms) merged 9 commits into
microsoft:0.64-stablefrom
acoates-ms:publishfix
Oct 28, 2021
Merged

[0.64] Fix publish builds by removing workspace from package.json before publish#866
Andrew Coates (acoates-ms) merged 9 commits into
microsoft:0.64-stablefrom
acoates-ms:publishfix

Conversation

@acoates-ms

@acoates-msAndrew Coates (acoates-ms) commented Oct 26, 2021•
edited
Loading

Copy link
Copy Markdown

@mganandraj
Some more changes for bringing up RN64 in devmain Android (react#861)
8960e85
* Build & Packaging changes for bringing up RN64 in devmain
* Fixing gradle clean
* Disable gradle clean in PR builds
@msgharpuMayuresh Gharpure
Fix for submit button disappearing bug in comments (react#862)
f9f7f8d
* Add the missing android folder to files in package.json
* Fix for submit button disappear bug in comments
Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com>
@tido64
fix: ensure scripts always have Unix newlines (react#860)
78a879c
@acoates-ms
Fix for publishing from stable branches
952f43a
@pull-bot

Pull Request Analyser (pull-bot) commented Oct 26, 2021•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 16e3a84

@acoates-msAndrew Coates (acoates-ms) changed the title Bring in latest changes from master, and also #865Fix publish builds by removing workspace from package.json before publishOct 27, 2021
@acoates-msAndrew Coates (acoates-ms) changed the title Fix publish builds by removing workspace from package.json before publish[0.64] Fix publish builds by removing workspace from package.json before publishOct 28, 2021
@acoates-msAndrew Coates (acoates-ms) mentioned this pull request Oct 28, 2021
Closed
4 tasks
@acoates-ms
Andrew Coates (acoates-ms) merged commit 1dc7d83 into microsoft:0.64-stableOct 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alloyEloy Durán (alloy)Awaiting requested review from alloy
1 more reviewer
@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acoates-ms@pull-bot@HeyImChris@mganandraj@msgharpu@tido64