') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Remove postinstall script by Saadnajmi · Pull Request #942 · microsoft/react-native-macos · GitHub
Skip to content

Remove postinstall script - #942

Merged
Saad Najmi (Saadnajmi) merged 25 commits into
microsoft:mainfrom
Saadnajmi:remove-postinstall
Jan 25, 2022
Merged

Remove postinstall script#942
Saad Najmi (Saadnajmi) merged 25 commits into
microsoft:mainfrom
Saadnajmi:remove-postinstall

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Jan 9, 2022

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Way back in #244 , we added a postinstall script to set the executable bit on our scripts. This was needed because we our publish pipeline at the time was running on a windows VM Image, and the windows filesystem doesn't have an executable bit. We no longer need to run on windows VM images, so this is no longer necessary.

Additionally, post install scripts are a security concern, so it's best we remove unnecessary ones.

This change also removes the last usage of a windows VM in our publish pipeline: the react-native-macos-init publish job.

Changelog

[Internal] [Security] - Removed postinstall script

Test Plan

I can't actually test this as this is a publish pipeline, but I have a few reasons to believe it's safe:

Saad Najmi (Saadnajmi)and others added 22 commits March 22, 2021 14:59
@Saadnajmi
add pull yml
c2b2e2f
@Saadnajmi
Merge pull request#1from microsoft/master
ab88c7d
[pull] master from microsoft:master
@pull@ryanlntn
match handleOpenURLNotification event payload with iOS (microsoft#755) (
7a9006b
#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
@Saadnajmi
Merge pull request#3from microsoft/master
497aa72
[pull] master from microsoft:master
@Saadnajmi
Merge pull request#4from microsoft/master
1c81e5b
[pull] master from microsoft:master
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
28aed35
@Saadnajmi
Merge branch 'master' of github.com:Saadnajmi/react-native-macos
62dc473
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
93c7296
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
780b2b7
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
99d5182
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
09e872d
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
9a25530
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
d82a01b
@pull@ntre
@mganandraj@Saadnajmi@ryanlntnMuhammad Hamza Zaman
[pull] master from microsoft:master (#11)
d9faa3a
* Deprecated api (microsoft#853)
* Remove deprecated/unused context param
* Update a few Mac deprecated APIs
* Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852)
* Ignore javadoc failure
* Bringing few more changes from 0.63-stable
* Fixing a patch in engine selection
* Fixing a patch in nuget spec
* Fixing the output directory of nuget pack
* Packaging dependencies in the nuget
* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)
* add pull yml
* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* fix mouse evetns on pressable
* delete extra yml from this branch
* Add macOS tags
* reorder props to have onMouseEnter/onMouseLeave always be before onPress
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
* Grammar fixes. (microsoft#856)
Updates simple grammar issues.
Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com>
Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
39bd488
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
c583ed3
@Saadnajmi
Merge branch 'master' of github.com:Saadnajmi/react-native-macos
9cea270
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
7571092
@Saadnajmi
Merge branch 'master' of github.com:microsoft/react-native-macos
2153ef5
@Saadnajmi
Merge branch 'microsoft:master' into master
47ee4ab
@Saadnajmi
remove postinstall script
168bb04
@Saadnajmi
remove fork specific change
7a25e37
@pull-bot

Pull Request Analyser (pull-bot) commented Jan 9, 2022•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 08964d3

@Saadnajmi

Saad Najmi (Saadnajmi) commented Jan 9, 2022•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Fails
🚫
❗ Base Branch - The base branch for this PR is something other than master. Are you sure you want to target something other than the master branch?

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Generated by 🚫 dangerJS against 7a25e37

HeyImChris Probably should fix this somehow too, still think's we're master. EDIT: #946 should do that.

HeyImChris
HeyImChris approved these changes Jan 10, 2022
View reviewed changes
Comment thread.ado/publish.yml Outdated
@Saadnajmi

Saad Najmi (Saadnajmi) commented Jan 15, 2022

Copy link
Copy Markdown
CollaboratorAuthor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Jan 24, 2022
Merged
4 tasks
kelset
Lorenzo Sciandra (kelset) reviewed Jan 24, 2022
View reviewed changes
Comment thread.ado/publish.yml
@Saadnajmi

Saad Najmi (Saadnajmi) commented Jan 25, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Interestingly enough react-native-macos-init hasn't had a new release in 2 years: https://www.npmjs.com/package/react-native-macos-init

This makes sense to me, as I haven't seen any changes to this package in this repo in ~2 years. Regardless, that helps me consider this an even more safe change so I'll go ahead and merge it.

@Saadnajmi
Saad Najmi (Saadnajmi) merged commit a51a1d1 into microsoft:mainJan 25, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the remove-postinstall branch January 25, 2022 21:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alloyEloy Durán (alloy)Awaiting requested review from alloy
2 more reviewers
@kelsetLorenzo Sciandra (kelset)kelset left review comments
@HeyImChrisHeyImChrisHeyImChris approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Saadnajmi@pull-bot@kelset@HeyImChris