Upgrade from 0.66.0 to 0.66.4 by HeyImChris · Pull Request #977 · microsoft/react-native-macos

HeyImChris · 2022-01-22T00:44:14Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

Integrated down up to 0.66.4, which is the latest release candidate for the 0.66-stable upstream branch, so this should catch us up!

Test Plan

I launched both the iOS/macOS test apps and was able to click through a couple different screens, scroll, etc.

Summary: Changelog: [General][Added] - Added data field to markerPoint to allow callers to add additional arbitrary string data to logged points Reviewed By: dmitry-voronkevich Differential Revision: D29764274 fbshipit-source-id: b0d21e3b20a5353351424afb10c950f3e8689887

Summary: UIAccessibilityVoiceOverStatusChanged deprecated (iOS 11+) in favor for UIAccessibilityVoiceOverStatusDidChangeNotification ref: https://developer.apple.com/documentation/uikit/uiaccessibilityvoiceoverstatuschanged?language=objc topLayoutGuide/bottomLayoutGuide deprecated (iOS 11+) in favor for safeAreaLayoutGuide ref: https://developer.apple.com/documentation/uikit/uiviewcontroller/1621367-toplayoutguide This block declaration is not a prototype warnings fixed by adding void to specify no parameters ref: https://stackoverflow.com/questions/47916585/objective-c-block-parameter-issue-this-block-declaration-is-not-a-prototype ## Changelog  [Internal] [Fixed] - Resolved some deprecations Pull Request resolved: react#31883 Test Plan: Tests should pass, no functionality should change. Reviewed By: fkgozali Differential Revision: D29822033 Pulled By: mdvacca fbshipit-source-id: dec8d612885634aca090ac3372cd4c7bf8a197ee

…es (react#28008) Summary: Fix for react#27952. Noticed more than just `AUTOFILL_HINT_NEW_PASSWORD` were missing, this PR will support every `AUTOFILL_HINT_*` type. ## Changelog [Android] [Added] - Added all autofill types to TextEdit Pull Request resolved: react#28008 Reviewed By: sturmen Differential Revision: D29766235 Pulled By: mdvacca fbshipit-source-id: d5171aef8092d37716fddcb6f3443637a4af8481

…#31880) Summary: The polyfills for `Object.entries` and `Object.values` are in a file named `Object.es7.js` when these APIs form part of ES8/ES2017 (https://en.wikipedia.org/wiki/ECMAScript#8th_Edition_–_ECMAScript_2017). The docs (https://reactnative.dev/docs/javascript-environment#polyfills) list these correctly as ES8 so I thought it might reduce confusion if anyone starts looking into the polyfills in the future like I did. ## Changelog  [Internal] [Fixed] - Fix filename to include correct ECMA spec Pull Request resolved: react#31880 Test Plan: All unit tests pass. Reviewed By: yungsters Differential Revision: D29820165 Pulled By: ShikaSD fbshipit-source-id: 2a4eb58bed7b7a4089406665c5c9115cb1773ff6

Summary: This diff integrates RCTImpressionTrackingView into Fabric on Android Following https://www.internalfb.com/intern/wiki/React_Native/Migration_of_RN_Renderer_(Fabric)/ and https://fb.quip.com/T8AtArEVcb0Z Changelog: [Internal] Reviewed By: bearzx Differential Revision: D29804625 fbshipit-source-id: 16e89d629390093ace51d3b25725c37a49a08a39

Summary: Added to C++ props, but realized this is already implemented using C++ state in Android, so added to C++ state to keep this diff simpler. Keeping the C++ props change for future use. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D29805267 fbshipit-source-id: c1fe2dc34af8bc69352ee48a5d60ba998194e3f7

Summary: Manually remove some existential types. Changelog: [Internal] Reviewed By: gkz Differential Revision: D29724881 fbshipit-source-id: e21558dc033fa07d0b8a188eb64e14ddcf7df2ac

Summary: Changelog: [Internal] Reviewed By: pieterv Differential Revision: D29724915 fbshipit-source-id: 97cbeefbba2ddc2e1088dfe19db14fa545213549

Summary: Changelog: [Internal] Reviewed By: gkz Differential Revision: D29833943 fbshipit-source-id: cb0260e1f4119b4208d42ef1267e253f6f84ff19

Summary: Tests like `CatalystSubviewsClippingTestCase` are intermittently failing due to registered callable modules not yet being registered. Increasing the timeout to wait for the bundle execution to mitigate these intermittent failures. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D29835227 fbshipit-source-id: c9fe03202ad4028d3785216d50c6c173a56c6d84

Summary: * it says focusTextInput but the function name is blurTextInput * probably the message was copy-pasted from `focusTextInput` where is the same error message. Changelog: [Internal] Reviewed By: arhelmus Differential Revision: D29845922 fbshipit-source-id: 21fd3e572c32779c13f6909556153d07dc7a416f

Summary: Changelog: [Internal] - RNTester: Add flow to RNTesterModuleContainer, render example as component, remove flowfixmes from Animation examples Reviewed By: yungsters Differential Revision: D29783772 fbshipit-source-id: 64ec6f247822b25c8cc6f64b192d17081be9c1f9

Summary: Changelog: [Internal] - Update Animation examples to toggle useNativeDriver There are issues when we toggle the native driver on and off. Where once off, the animations don't seem to update anymore, until we turn nativeDriver back on. See videos in testplan Reviewed By: yungsters Differential Revision: D29774939 fbshipit-source-id: cf6d70c1b574a87bb803510196dfb273b36de5e1

…eption Summary: - This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features. Reviewed By: JoshuaGross Differential Revision: D29857626 fbshipit-source-id: c52cfb6131747ae420b27de0591620fe79f47359

Summary: Add INFO, and MENU key event support to Android TV ## Changelog [Android] [Added] - Add INFO, and MENU key event support to Android TV Pull Request resolved: react#31884 Test Plan: We develop application that utilizes aforementioned events, we've made a build against react-native fork with these changes and it was working as expected. These changes just add 2 more button mappings, so I don't think it requires some extensive testing. Reviewed By: mdvacca Differential Revision: D29821996 Pulled By: yungsters fbshipit-source-id: 5f97c29c9c29d6e3bafed352b8b65f0cb02f3f1d

Summary: Includes fix included in a Flipper Pod for incorrect timestamps in the Network viewer with iOS apps facebook/flipper@1cf7456 ## Changelog  [general][changed] - Update Flipper to 0.99.0 [CATEGORY] [TYPE] - Message Pull Request resolved: react#31896 Reviewed By: fkgozali Differential Revision: D29881218 Pulled By: mdvacca fbshipit-source-id: a206faa3d7b969a708d286884cff83bed5453d22

…act#31865) Summary: With the advent of react#29610, we are now able to use the `testID` view prop on Android in black-box testing framework through the view's `resource-id`. But after testing it, I noticed that on the `TextInput`, `Slider` and `ScrollView` components, the `testID` prop was not exposed as the `resource-id` properly. The main issue was that those component was using the `AccessibilityDelegateCompat` instead of the `ReactAccessibilityDelegate`. ## Changelog [Android] [Fixed] - Fix `testID` prop for `TextInput`, `Slider` and `ScrollView` components Pull Request resolved: react#31865 Test Plan: ![test-screenshot](https://user-images.githubusercontent.com/69216913/125802180-c0791a8c-a740-4657-a44f-42b1885eee39.png) Reviewed By: mdvacca Differential Revision: D29765333 Pulled By: yungsters fbshipit-source-id: 2b8e362257e3e5fdcd20330280c588dabb44f28a

Summary: Similar to D29786190 (react@b0e39b2) on iOS, keeps cursor position constant to the end of the text whenever text changes without selection updates. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D29879663 fbshipit-source-id: da1b50a99ae3b9ef796423146ba49e4172e286df

…EADLOCK Summary: This diff exposes a new API Expose new API RuntimeExecutor.executeSynchronouslyOnSameThread_CAN_DEADLOCK. This API will be used by the next diffs of the stack changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D29764996 fbshipit-source-id: e6cd6799e16f2e47a353b7504d58d80aa49447d8

Summary: This diff exposes a new struct InspectorData that will be used by FabricUIManager.getInspectorDataForInstance to return metadata of stacktraces. See next diffs of the stack changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D29764995 fbshipit-source-id: 6a2ab819623e379795e59002be0e4d40ac73b9a6

Summary: This diff exposes a new API in FabricUIManager called getInspectorDataForInstance. The goal of this method is to return React metadata for a Native view. This data will be used from partner teams to build tools that uses React metadata in RN Data returned from React: P429701924 changelog: [internal] internal allow-large-files Reviewed By: JoshuaGross Differential Revision: D29747864 fbshipit-source-id: 8cb55573be08cb530f7e3c83eed8b4fcf43e7781

Summary: This sync includes the following changes: - **[cae6350](react/react@cae635054 )**: `act`: Resolve to return value of scope function ([react#21759](react/react#21759)) //<Andrew Clark>// - **[e2453e2](react/react@e2453e200 )**: act: Add test for bypassing queueMicrotask ([react#21743](react/react#21743)) //<Andrew Clark>// - **[534c9c5](react/react@534c9c52e )**: Move error logging to update callback ([react#21737](react/react#21737)) //<Dan Abramov>// - **[51b0bec](react/react@51b0becf3 )**: Always keep disabled logs in the second pass ([react#21739](react/react#21739)) //<Dan Abramov>// - **[7fec380](react/react@7fec38041 )**: Log and show error overlay for commit phase errors ([react#21723](react/react#21723)) //<Dan Abramov>// - **[27c9c95](react/react@27c9c95e2 )**: act: Bypass microtask for "default sync" updates ([react#21740](react/react#21740)) //<Andrew Clark>// - **[355591a](react/react@355591add )**: Next/experimental release versions include commit date ([react#21700](react/react#21700)) //<Brian Vaughn>// - **[d7dce57](react/react@d7dce572c )**: Remove internal `act` builds from public modules ([react#21721](react/react#21721)) //<Andrew Clark>// - **[06f7b4f](react/react@06f7b4f43 )**: `act` should work without mock Scheduler ([react#21714](react/react#21714)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 568dc35...cae6350 jest_e2e[run_all_tests] Reviewed By: JoshuaGross, ShikaSD Differential Revision: D29555979 fbshipit-source-id: 0afc869cc007bce417f0020d3ee4dc8b0ea5beb9

Summary: Changelog: [internal] If task that is being executed schedules a new task with higher priority, the new task will be dropped from the queue. To fix this, we always check if the top of the queue is what was executed and only then remove it. Example: Let's say there is task A with priority "normal". When we execute task A (which is not removed from the queue until later), it adds a task B with "immediate" priority. So priority queue now has two tasks: [1: B, 2: A] After task A finishes, inside workLoop, it will pop from top of the priority queue. But task A is no longer top of the priority queue (this is the bug) and it pops B. B is never executed and A is executed twice. Reviewed By: ShikaSD Differential Revision: D29841433 fbshipit-source-id: b2f1474fdfc7b3e2d42bae5b7f4ac7e6c3a37b54

Summary: In T94154173, when calling ```EventEmitterWrapper->invoke()```, hybrid function ```invokeEvent``` is null, even if we checked that ```mHybridData``` is valid before calling ```invokeEvent```. **Theory:** ```invoke()``` is called from ```mqt_js``` thread, ```desotry()``` is called from ```main``` thread, which cause multi-thread access of```mHybridData```. So if ```desotry()``` is called after ```isValid()``` check and before calling ```invokeEvent()```, ```invokeEvent``` could be destroyed and is null. I can reproduce with above theory: {F633411001} **Fix:** Make functions synchronized so ```mHybridData``` can be thread safe. Changelog: [Android][Fixed] - Make mHybridData thread safe Reviewed By: RSNara Differential Revision: D29792453 fbshipit-source-id: 8b4c754d53ece933be7b2cf99c6cd026b39e24ad

Summary: **Context:** Issue: ```java.lang.IllegalStateException: Message queue threads already initialized at com.facebook.react.bridge.ReactContext.initializeMessageQueueThreads(ReactContext.java:100) ``` Possible root cause: 1, ReactContext.initializeMessageQueueThreads() can be called from different threads, so it's not thread safe 2, ReactContext.initializeMessageQueueThreads() is called again without detroying the threads. **Fix:** Make initializeMessageQueueThreads() thread safe. If this won't fix T93983690, I'll continue investigating with possible root cause 2. Changelog: [Android][Changed] - Make initializeMessageQueueThreads() thread safe Reviewed By: GijsWeterings Differential Revision: D29877386 fbshipit-source-id: 11b32c7184e9e8d6f882474fd607538df12276b7

Summary: Changelog: [Internal] Reviewed By: ShikaSD Differential Revision: D29896358 fbshipit-source-id: 83a9c124a01945706c4bdced8cf6e997e14f831c

Summary: Changelog: [internal] Original commit changeset: 390e773283a7 Original diff didn't resolve crash T82119127. Let's back this out and investigate again. Reviewed By: mdvacca Differential Revision: D29909878 fbshipit-source-id: 54b054f4a5c97b8f6369f8790c2cf32a56c4fbd2

…uring teardown" Summary: Changelog: [internal] Original commit changeset: 6cb898caf7c2 This change doesn't fix LayoutAnimation crashes. Let's back it out. Reviewed By: fkgozali Differential Revision: D29909973 fbshipit-source-id: 34926ace220e6b269bb938a3da72c977b0608187

Summary: There was an unused example in ScrollView example, so I've added the example to RNTester App ## Changelog  [Internal] [Added] - Added persistentScrollbar option example for ScrollView in RNTester App Pull Request resolved: react#31895 Test Plan: - RNTester App builds and shows example properly on Android Reviewed By: sshic Differential Revision: D29881126 Pulled By: mdvacca fbshipit-source-id: 9e7e61c9d3f712cb767a78e729469fc95cb9953e

Summary: Fixed a link in a comment that lead to dead link whatwg-url changed the source directory from `lib` to `src` ## Changelog  [INTERNAL] [FIXED] - fix dead link in a comment Pull Request resolved: react#31902 Test Plan: - [ ] Changed URL opens properly Reviewed By: charlesbdudley Differential Revision: D29915170 Pulled By: lunaleaps fbshipit-source-id: 00b69db82f51d16cf887cd4540a159132ad7d771

Pull Request Analyser (pull-bot) · 2022-01-22T00:51:33Z

	Warnings
⚠️	❔ Base Branch - The base branch for this PR is something other than `main`. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on `main` first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General macOS iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against ef75590

Saad Najmi (Saadnajmi) · 2022-01-22T00:48:14Z

 RCTVersionMajor: @(0),
 RCTVersionMinor: @(66),
- RCTVersionPatch: @(0),
+ RCTVersionPatch: @(4),


We'll want to undo this in main, which I guess my other review does.

…-version-invocation

Code Analyser (analysis-bot)

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

Code Analyser (analysis-bot) · 2022-01-25T02:15:08Z

 public interface BundleLoadCallback {
 void onSuccess();
-}
+}


google-java-format suggested changes:
@@ -14 +14 @@-} \ No newline at end of file +}

Code Analyser (analysis-bot)

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

Code Analyser (analysis-bot) · 2022-01-25T04:33:08Z

 public interface BundleLoadCallback {
 void onSuccess();
-}
+}


google-java-format suggested changes:
@@ -14 +14 @@-} \ No newline at end of file +}

Code Analyser (analysis-bot)

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

Code Analyser (analysis-bot) · 2022-01-25T06:01:40Z

 public interface BundleLoadCallback {
 void onSuccess();
-}
+}


google-java-format suggested changes:
@@ -14 +14 @@-} \ No newline at end of file +}

Code Analyser (analysis-bot)

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

Code Analyser (analysis-bot) · 2022-01-25T06:21:05Z

 public interface BundleLoadCallback {
 void onSuccess();
-}
+}


google-java-format suggested changes:
@@ -14 +14 @@-} \ No newline at end of file +}

HeyImChris · 2022-01-25T07:24:59Z

Merging as Apple builds are succeeding. Will follow up tomorrow with fixes for Android and Integration CI.

Mark Bridgesand others added 30 commits July 21, 2021 10:34

Manually some remove existential types from xplat/js
24ba0db
Summary: Manually remove some existential types. Changelog: [Internal] Reviewed By: gkz Differential Revision: D29724881 fbshipit-source-id: e21558dc033fa07d0b8a188eb64e14ddcf7df2ac

Remove existential types from xplat/js
afe0c1d
Summary: Changelog: [Internal] Reviewed By: pieterv Differential Revision: D29724915 fbshipit-source-id: 97cbeefbba2ddc2e1088dfe19db14fa545213549

Deploy 0.156.0 to xplat
a67799f
Summary: Changelog: [Internal] Reviewed By: gkz Differential Revision: D29833943 fbshipit-source-id: cb0260e1f4119b4208d42ef1267e253f6f84ff19

Handle OSS renderers in sync script
d272880
Summary: Changelog: [Internal] Reviewed By: ShikaSD Differential Revision: D29896358 fbshipit-source-id: 83a9c124a01945706c4bdced8cf6e997e14f831c

HeyImChris added 3 commits January 6, 2022 13:26

Merge branch 'main' ofhttps://github.com/microsoft/react-native-macos
f98de97

Merge branch 'main' ofhttps://github.com/microsoft/react-native-macos
b33a781

Merge remote-tracking branch 66.4
7f9510e

HeyImChris requested a review from Eloy Durán (alloy) as a code owner January 22, 2022 00:44

HeyImChris requested a review from Adam Gleitman (amgleitman)January 22, 2022 00:44

HeyImChris self-assigned this Jan 22, 2022

HeyImChris requested a review from Lorenzo Sciandra (kelset)January 22, 2022 00:47

Saad Najmi (Saadnajmi) approved these changes Jan 22, 2022
View reviewed changes

HeyImChrisand others added 4 commits January 21, 2022 19:19

update preprocessor/scrollview snapshots
d5704de

yarn flow-check{ios, macos, android}, lint
6f18052

Fix invocation of bump-oss-version.js in react-native-macos-init.yml
4e3d5ae

Merge pull request#11from amgleitman/amgleitman/0.66.4-fix-bump-oss…
e690ff7
…-version-invocation

Code Analyser (analysis-bot) suggested changes Jan 25, 2022
View reviewed changes

ghost added the Needs: Author Feedback label Jan 25, 2022

add dev team for code signing
29a3995

ghost removed the Needs: Author Feedback label Jan 25, 2022

Code Analyser (analysis-bot) suggested changes Jan 25, 2022
View reviewed changes

ghost added the Needs: Author Feedback label Jan 25, 2022

fix pbxproj duplicate output manifest
4909c2c

ghost removed the Needs: Author Feedback label Jan 25, 2022

Code Analyser (analysis-bot) suggested changes Jan 25, 2022
View reviewed changes

ghost added the Needs: Author Feedback label Jan 25, 2022

Fb added a nightly build flag that duplicates ci
ef75590

ghost removed the Needs: Author Feedback label Jan 25, 2022

Code Analyser (analysis-bot) suggested changes Jan 25, 2022
View reviewed changes

ghost added the Needs: Author Feedback label Jan 25, 2022

ghost removed the Needs: Author Feedback label Jan 25, 2022

HeyImChris merged commit e469dd7 into microsoft:0.66-stableJan 25, 2022

Navigation Menu

Uh oh!

Upgrade from 0.66.0 to 0.66.4 - #977

Upgrade from 0.66.0 to 0.66.4#977
HeyImChris merged 1793 commits into
microsoft:0.66-stablefrom
HeyImChris:66_4

HeyImChris commented Jan 22, 2022•
edited
Loading

Uh oh!

Pull Request Analyser (pull-bot) commented Jan 22, 2022•
edited
Loading

Uh oh!

Uh oh!

Saad Najmi (Saadnajmi)Jan 22, 2022

Uh oh!

Code Analyser (analysis-bot) left a comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Uh oh!

Code Analyser (analysis-bot) left a comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Uh oh!

Code Analyser (analysis-bot) left a comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Uh oh!

Code Analyser (analysis-bot) left a comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Uh oh!

HeyImChris commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

HeyImChris commented Jan 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please select one of the following

Summary

Test Plan

Uh oh!

Pull Request Analyser (pull-bot) commented Jan 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Saad Najmi (Saadnajmi)Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot) left a comment

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot) left a comment

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot) left a comment

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot) left a comment

Choose a reason for hiding this comment

Uh oh!

Code Analyser (analysis-bot)Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

HeyImChris commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

HeyImChris commented Jan 22, 2022•
edited
Loading

Pull Request Analyser (pull-bot) commented Jan 22, 2022•
edited
Loading