Skip to content

fix(macos): Fixes to macOS test app to suport MSAL authentication - #553

Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged

fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom
tom-un:tomun/macos-auth-fixes

Conversation

@tom-un

@tom-unTom Underhill (tom-un) commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Description

The macOS test app had two issues the prevented test apps from using the MSAL auth framework:

  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.

@tom-unTom Underhill (tom-un) changed the title Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64) reviewed Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
DEVELOPMENT_TEAM = UBF8T346G9;

@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?

@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj

tido64
Tommy Nguyen (tido64) approved these changes Oct 13, 2021
View reviewed changes

@tido64Tommy Nguyen (tido64) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️

@tido64
Tommy Nguyen (tido64) enabled auto-merge (squash) October 13, 2021 09:45
@tido64Tommy Nguyen (tido64) added the platform: macOS This affects macOS label Oct 13, 2021
@tido64
Tommy Nguyen (tido64) merged commit f73cdb9 into microsoft:trunkOct 13, 2021
@github-actions

github-actionsBot commented Oct 13, 2021

Copy link
Copy Markdown

🎉 This PR is included in version 0.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tido64Tommy Nguyen (tido64) mentioned this pull request Oct 16, 2021
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees

No one assigned

Labels

platform: macOSThis affects macOSreleased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(macos): Fixes to macOS test app to suport MSAL authentication by tom-un · Pull Request #553 · microsoft/react-native-test-app · GitHub
Skip to content
fix(macos): Fixes to macOS test app to suport MSAL authentication - #553
Merged
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Oct 13, 2021
Merged
fix(macos): Fixes to macOS test app to suport MSAL authentication#553
Tommy Nguyen (tido64) merged 3 commits into
microsoft:trunkfrom 
tom-un:tomun/macos-auth-fixes
Conversation
@tom-un
@tom-unTom Underhill (tom-un)
commented
Oct 13, 2021

Copy link


Copy Markdown

Contributor
Description
The macOS test app had two issues the prevented test apps from using the MSAL auth framework:
  1. The macOS AppDelegate's applicationDidFinishLaunching method was not firing the ReactTestAppDidInitialize notification as its iOS counterpart does. This notification is used in internal react-native-test-app support packages that provide MSAL auth.
  2. The macOS MSAL framework depends on group keychain access to com.microsoft.identity.universalstorage. This is similar to the iOS MSAL framework that depends on group keychain access to com.microsoft.adalcache. See MSIDKeychainTokenCache.m.
  • As a consequence of adding this entitlement, the macOS test app must be signed. So the macOS pbxproj was updated to sign similar to its iOS counterpart.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
  • Verified that yarn macos builds and runs in the example folder.
  • Ingested into local macOS test app that authenticates using MSAL framework and verified that it can successful auth.
@tom-unTom Underhill (tom-un)
changed the title
Fixes to macOS test app to suport MSAL authenticationfix(macos): Fixes to macOS test app to suport MSAL authenticationOct 13, 2021
tido64
Tommy Nguyen (tido64)
reviewed
Oct 13, 2021
View reviewed changes
Comment threadmacos/ReactTestApp.xcodeproj/project.pbxproj
 CODE_SIGN_IDENTITY = "Apple Development";
 CODE_SIGN_STYLE = Automatic;
 COMBINE_HIDPI_IMAGES = YES;
 DEVELOPMENT_TEAM = UBF8T346G9;
@tido64Tommy Nguyen (tido64)Oct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail for other people when Xcode can't find the team?
@tom-unTom Underhill (tom-un)Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because "Automatic signing" is on. The same development team string is in the iOS project.pbxproj
tido64
Tommy Nguyen (tido64)
approved these changes
Oct 13, 2021
View reviewed changes
@tido64Tommy Nguyen (tido64)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 13, 2021 09:45
@tido64Tommy Nguyen (tido64)
added
the 
platform: macOS
This affects macOS
label
Oct 13, 2021
@tido64
Tommy Nguyen (tido64)
merged commit f73cdb9
into
microsoft:trunkOct 13, 2021
@github-actions
github-actionsBot
commented
Oct 13, 2021

Copy link


Copy Markdown

🎉 This PR is included in version 0.9.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Oct 16, 2021
 Merged

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees


No one assigned


Labels

platform: macOSThis affects macOSreleased

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tom-un@tido64